Skip to content

Commit 057b923

Browse files
authored
fix: skip starlette check when server version is hidden (#696)
Fixes #695
1 parent 809d08e commit 057b923

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

docs/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased] - ??
99

10+
### Fixed
11+
12+
- Python Shiny apps can be deployed when Connect server version is hidden. (#695)
13+
1014
## [1.27.0] - 2025-07-10
1115

1216
### Added

rsconnect/main.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1694,12 +1694,20 @@ def deploy_app(
16941694

16951695
if isinstance(ce.client, RSConnectClient):
16961696
# Update the starlette version if needed. After all users are on Connect
1697-
# 2024.01.1 or later, this can be removed.
1698-
environment = fix_starlette_requirements(
1699-
environment=environment,
1700-
app_mode=app_mode,
1701-
connect_version_string=ce.client.server_settings()["version"],
1702-
)
1697+
# 2024.01.1 or later, this can be removed. Requires access to the
1698+
# Connect server version, which may be hidden.
1699+
connect_version_string = ce.client.server_settings().get("version", "")
1700+
if connect_version_string:
1701+
environment = fix_starlette_requirements(
1702+
environment=environment,
1703+
app_mode=app_mode,
1704+
connect_version_string=connect_version_string,
1705+
)
1706+
else:
1707+
click.secho(
1708+
" Warning: Connect server version is hidden. Skipping starlette requirements check.",
1709+
fg="yellow",
1710+
)
17031711

17041712
ce.validate_server()
17051713
ce.validate_app_mode(app_mode=app_mode)

0 commit comments

Comments
 (0)