Skip to content

Commit 7ac3505

Browse files
apbosemering
andauthored
Removal of BAZEL build files from python package and changes to make cpp tests work (#3641)
Co-authored-by: Marcel <maleo@google.com>
1 parent d808c0a commit 7ac3505

File tree

7 files changed

+36
-18
lines changed

7 files changed

+36
-18
lines changed

BUILD.bazel

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@ pkg_tar(
8888
name = "libtorchtrt",
8989
srcs = [
9090
"//:LICENSE",
91-
"//bzl_def:BUILD",
92-
"//bzl_def:WORKSPACE",
91+
"//third_party/torch_tensorrt:BUILD",
9392
],
9493
extension = "tar.gz",
9594
package_dir = "torch_tensorrt",
@@ -107,8 +106,7 @@ pkg_tar(
107106
name = "libtorchtrt_runtime",
108107
srcs = [
109108
"//:LICENSE",
110-
"//bzl_def:BUILD",
111-
"//bzl_def:WORKSPACE",
109+
"//third_party/torch_tensorrt:BUILD",
112110
],
113111
extension = "tar.gz",
114112
package_dir = "torch_tensorrt_runtime",

MODULE.bazel

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,16 @@ git_override(
2424

2525
local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "local_repository")
2626

27+
28+
new_local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "new_local_repository")
29+
2730
# External dependency for torch_tensorrt if you already have precompiled binaries.
28-
local_repository(
31+
new_local_repository(
2932
name = "torch_tensorrt",
30-
path = "/opt/conda/lib/python3.11/site-packages/torch_tensorrt",
33+
build_file = "@//third_party/torch_tensorrt:BUILD",
34+
path = "/usr/local/lib/python3.12/site-packages/torch_tensorrt/",
3135
)
3236

33-
new_local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "new_local_repository")
34-
3537
# CUDA should be installed on the system locally
3638
# for linux x86_64 and aarch64
3739
new_local_repository(

bzl_def/WORKSPACE

Lines changed: 0 additions & 1 deletion
This file was deleted.

docker/MODULE.bazel.ngc

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,17 @@ git_override(
2424

2525
local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "local_repository")
2626

27+
28+
new_local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "new_local_repository")
29+
30+
2731
# External dependency for torch_tensorrt if you already have precompiled binaries.
28-
local_repository(
32+
new_local_repository(
2933
name = "torch_tensorrt",
34+
build_file = "@//third_party/torch_tensorrt:BUILD",
3035
path = "/usr/local/lib/python3.12/dist-packages/torch_tensorrt/",
3136
)
3237

33-
new_local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "new_local_repository")
34-
3538

3639
# CUDA should be installed on the system locally
3740
new_local_repository(
@@ -55,8 +58,29 @@ new_local_repository(
5558
build_file = "third_party/libtorch/BUILD"
5659
)
5760

61+
62+
# This is a workaround (WAR), not a functional Bazel repository.
63+
# It directly references a system-installed PyTorch package, which breaks hermeticity
64+
new_local_repository(
65+
name = "torch_l4t",
66+
path = "/usr/local/lib/python3.12/dist-packages/torch/",
67+
build_file = "third_party/libtorch/BUILD"
68+
)
69+
5870
new_local_repository(
5971
name = "tensorrt",
6072
path = "/usr/",
6173
build_file = "@//third_party/tensorrt/local:BUILD"
6274
)
75+
76+
new_local_repository(
77+
name = "tensorrt_sbsa",
78+
path = "/usr/",
79+
build_file = "@//third_party/tensorrt/local:BUILD"
80+
)
81+
82+
new_local_repository(
83+
name = "tensorrt_l4t",
84+
path = "/usr/",
85+
build_file = "@//third_party/tensorrt/local:BUILD"
86+
)

setup.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -597,8 +597,6 @@ def run(self):
597597
package_data.update(
598598
{
599599
"torch_tensorrt": [
600-
"BUILD",
601-
"WORKSPACE",
602600
"include/torch_tensorrt/*.h",
603601
"include/torch_tensorrt/core/*.h",
604602
"include/torch_tensorrt/core/conversion/*.h",
@@ -628,8 +626,6 @@ def run(self):
628626
package_data.update(
629627
{
630628
"torch_tensorrt": [
631-
"BUILD",
632-
"WORKSPACE",
633629
"include/torch_tensorrt/*.h",
634630
"include/torch_tensorrt/core/*.h",
635631
"include/torch_tensorrt/core/runtime/*.h",
File renamed without changes.
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package(default_visibility = ["//visibility:public"])
22

33
exports_files([
4-
"WORKSPACE",
54
"BUILD",
6-
])
5+
])

0 commit comments

Comments
 (0)