fix(pluginutils): Escape glob characters in folder (#84)

Author: NotWoods

packages/pluginutils/src/createFilter.ts

@@ -1,16 +1,22 @@
-import { resolve, sep } from 'path';
+import { resolve, join, sep } from 'path';
 
 import mm from 'micromatch';
 
 import { CreateFilter } from '../types';
 
 import ensureArray from './utils/ensureArray';
 
+const ESCAPE_IN_PATH = '()+@!'
+
 function getMatcherString(id: string, resolutionBase: string | false | null | undefined) {
   if (resolutionBase === false) {
     return id;
   }
-  return resolve(...(typeof resolutionBase === 'string' ? [resolutionBase, id] : [id]));
+  let basePath = typeof resolutionBase === 'string' ? resolve(resolutionBase) : process.cwd();
+  for (const char of ESCAPE_IN_PATH) {
+    basePath = basePath.replace(new RegExp(`\\${char}`, 'g'), `\\${char}`);
+  }
+  return join(basePath, id);
 }
 
 const createFilter: CreateFilter = function createFilter(include?, exclude?, options?) {

packages/pluginutils/test/createFilter.ts

@@ -4,6 +4,8 @@ import test from 'ava';
 
 import { createFilter } from '../';
 
+test.beforeEach(() => process.chdir(__dirname));
+
 test('includes by default', (t) => {
   const filter = createFilter();
   t.truthy(filter(resolve('x')));
@@ -107,3 +109,11 @@ test('includes names starting with a "."', (t) => {
   t.truthy(filter(resolve('.a')));
   t.truthy(filter(resolve('.x/a')));
 });
+
+test.serial('includes names containing parenthesis', (t) => {
+  process.chdir(resolve(__dirname, 'fixtures/folder-with (parens)'));
+  const filter = createFilter(['*.ts+(|x)', '**/*.ts+(|x)'], ['*.d.ts', '**/*.d.ts']);
+  t.truthy(filter(resolve('folder (test)/src/main.tsx')));
+  t.truthy(filter(resolve('.x/(test)a.ts')));
+  t.falsy(filter(resolve('.x/(test)a.d.ts')));
+});