PHPStan level 4

Author: franmomu

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 * Updated `symfony/phpunit-bridge` to `6.0` by @franmomu [#2067](https://github.com/ruflin/Elastica/pull/2067)
 * Updated `php-cs-fixer` to `3.8.0` [#2074](https://github.com/ruflin/Elastica/pull/2074)
+* Increased `PHPStan` level to `4` [#2080](https://github.com/ruflin/Elastica/pull/2080)
 ### Deprecated
 * Deprecated `Elastica\Reindex::WAIT_FOR_COMPLETION_FALSE`, use a boolean as parameter instead by @franmomu [#2070](https://github.com/ruflin/Elastica/pull/2070)
 * Passing anything else than a boolean as 1st argument to `Reindex::setWaitForCompletion`, pass a boolean instead by @franmomu [#2070](https://github.com/ruflin/Elastica/pull/2070)

phpstan-baseline.neon

@@ -75,6 +75,31 @@ parameters:
 			count: 1
 			path: tests/DocumentTest.php
 
+		-
+			message: "#^Dead catch \\- Elastica\\\\Exception\\\\InvalidException is never thrown in the try block\\.$#"
+			count: 1
+			path: tests/DocumentTest.php
+
+		-
+			message: "#^Expression \"\\$document\\-\\>field5\" on a separate line does not do anything\\.$#"
+			count: 1
+			path: tests/DocumentTest.php
+
+		-
+			message: "#^Unreachable statement \\- code above always terminates\\.$#"
+			count: 1
+			path: tests/DocumentTest.php
+
+		-
+			message: "#^Unreachable statement \\- code above always terminates\\.$#"
+			count: 1
+			path: tests/IndexTest.php
+
+		-
+			message: "#^Unreachable statement \\- code above always terminates\\.$#"
+			count: 2
+			path: tests/Multi/SearchTest.php
+
 		-
 			message: "#^Call to an undefined method ReflectionType\\:\\:getName\\(\\)\\.$#"
 			count: 2
@@ -95,6 +120,16 @@ parameters:
 			count: 1
 			path: tests/QueryBuilderTest.php
 
+		-
+			message: "#^Expression \"\\$index\\-\\>search\\('elastica search'\\)\\[3\\]\" on a separate line does not do anything\\.$#"
+			count: 1
+			path: tests/ResultSetTest.php
+
+		-
+			message: "#^Unreachable statement \\- code above always terminates\\.$#"
+			count: 1
+			path: tests/SnapshotTest.php
+
 		-
 			message: "#^Call to an undefined method GuzzleHttp\\\\Exception\\\\TransferException\\:\\:getRequest\\(\\)\\.$#"
 			count: 6

phpstan.neon

@@ -3,13 +3,14 @@ includes:
     - phpstan-baseline.neon
 
 parameters:
-    level: 3
+    level: 4
     paths:
         - src
         - tests
     excludePaths:
         - src/Transport/HttpAdapter.php
         - src/Query/Match.php
+    treatPhpDocTypesAsCertain: false
     ignoreErrors:
         # we don't have different constructors for parent/child
         - '~^Unsafe usage of new static\(\)\.$~'

tests/Collapse/CollapseTest.php

@@ -112,10 +112,12 @@ public function testSetInnerHitsOverridesExistingValue(): void
         $collapse->setInnerHits($innerHits1);
         $collapse->addInnerHits($innerHits2);
 
-        $this->assertCount(2, $collapse->getParam('inner_hits'));
-        $this->assertIsArray($collapse->getParam('inner_hits'));
-        $this->assertEquals($innerHits1, $collapse->getParam('inner_hits')[0]);
-        $this->assertEquals($innerHits2, $collapse->getParam('inner_hits')[1]);
+        $innerHits = $collapse->getParam('inner_hits');
+
+        $this->assertCount(2, $innerHits);
+        $this->assertIsArray($innerHits);
+        $this->assertEquals($innerHits1, $innerHits[0]);
+        $this->assertEquals($innerHits2, $innerHits[1]);
 
         $innerHitsOverride = new InnerHits();
         $innerHitsOverride->setName('override');