fix: include version in npm release URL

Author: pvdlg

lib/get-release-info.js

@@ -4,7 +4,7 @@ const normalizeUrl = require('normalize-url');
 module.exports = async (
   npmrc,
   {name, publishConfig: {tag} = {}},
-  {cwd, env: {DEFAULT_NPM_REGISTRY = 'https://registry.npmjs.org/', ...env}},
+  {cwd, env: {DEFAULT_NPM_REGISTRY = 'https://registry.npmjs.org/', ...env}, nextRelease: {version}},
   registry
 ) => {
   const distTag =
@@ -14,7 +14,7 @@ module.exports = async (
     name: `npm package (@${distTag} dist-tag)`,
     url:
       normalizeUrl(registry) === normalizeUrl(DEFAULT_NPM_REGISTRY)
-        ? `https://www.npmjs.com/package/${name}`
+        ? `https://www.npmjs.com/package/${name}/v/${version}`
         : undefined,
   };
 };

lib/publish.js

@@ -23,7 +23,7 @@ module.exports = async (npmrc, {npmPublish, pkgRoot}, pkg, context) => {
     result.stderr.pipe(stderr, {end: false});
     await result;
 
-    logger.log(`Published ${pkg.name}@${pkg.version} on ${registry}`);
+    logger.log(`Published ${pkg.name}@${version} on ${registry}`);
     return getReleaseInfo(npmrc, pkg, context, registry);
   }
 

test/get-release-info.test.js

@@ -16,30 +16,54 @@ test('Default registry and tag', async t => {
   const cwd = tempy.directory();
   const npmrc = tempy.file({name: '.npmrc'});
 
-  t.deepEqual(await getReleaseInfo(npmrc, {name: 'module'}, {cwd, env: {}}, 'https://registry.npmjs.org/'), {
-    name: 'npm package (@latest dist-tag)',
-    url: 'https://www.npmjs.com/package/module',
-  });
+  t.deepEqual(
+    await getReleaseInfo(
+      npmrc,
+      {name: 'module'},
+      {cwd, env: {}, nextRelease: {version: '1.0.0'}},
+      'https://registry.npmjs.org/'
+    ),
+    {
+      name: 'npm package (@latest dist-tag)',
+      url: 'https://www.npmjs.com/package/module/v/1.0.0',
+    }
+  );
 });
 
 test('Default registry, tag and scoped module', async t => {
   const cwd = tempy.directory();
   const npmrc = tempy.file({name: '.npmrc'});
 
-  t.deepEqual(await getReleaseInfo(npmrc, {name: '@scope/module'}, {cwd, env: {}}, 'https://registry.npmjs.org/'), {
-    name: 'npm package (@latest dist-tag)',
-    url: 'https://www.npmjs.com/package/@scope/module',
-  });
+  t.deepEqual(
+    await getReleaseInfo(
+      npmrc,
+      {name: '@scope/module'},
+      {cwd, env: {}, nextRelease: {version: '1.0.0'}},
+      'https://registry.npmjs.org/'
+    ),
+    {
+      name: 'npm package (@latest dist-tag)',
+      url: 'https://www.npmjs.com/package/@scope/module/v/1.0.0',
+    }
+  );
 });
 
 test('Custom registry, tag and scoped module', async t => {
   const cwd = tempy.directory();
   const npmrc = tempy.file({name: '.npmrc'});
 
-  t.deepEqual(await getReleaseInfo(npmrc, {name: '@scope/module'}, {cwd, env: {}}, 'https://custom.registry.org/'), {
-    name: 'npm package (@latest dist-tag)',
-    url: undefined,
-  });
+  t.deepEqual(
+    await getReleaseInfo(
+      npmrc,
+      {name: '@scope/module'},
+      {cwd, env: {}, nextRelease: {version: '1.0.0'}},
+      'https://custom.registry.org/'
+    ),
+    {
+      name: 'npm package (@latest dist-tag)',
+      url: undefined,
+    }
+  );
 });
 
 test('Default registry and tag from .npmrc', async t => {
@@ -48,10 +72,15 @@ test('Default registry and tag from .npmrc', async t => {
   await writeFile(npmrc, 'tag=npmrc');
 
   t.deepEqual(
-    await getReleaseInfo(npmrc, {name: 'module', publishConfig: {}}, {cwd, env: {}}, 'https://registry.npmjs.org/'),
+    await getReleaseInfo(
+      npmrc,
+      {name: 'module', publishConfig: {}},
+      {cwd, env: {}, nextRelease: {version: '1.0.0'}},
+      'https://registry.npmjs.org/'
+    ),
     {
       name: 'npm package (@npmrc dist-tag)',
-      url: 'https://www.npmjs.com/package/module',
+      url: 'https://www.npmjs.com/package/module/v/1.0.0',
     }
   );
 });
@@ -66,10 +95,10 @@ test('Default registry and tag from package.json', async t => {
     await getReleaseInfo(
       npmrc,
       {name: 'module', publishConfig: {tag: 'pkg'}},
-      {cwd, env: {}},
+      {cwd, env: {}, nextRelease: {version: '1.0.0'}},
       'https://registry.npmjs.org/'
     ),
-    {name: 'npm package (@pkg dist-tag)', url: 'https://www.npmjs.com/package/module'}
+    {name: 'npm package (@pkg dist-tag)', url: 'https://www.npmjs.com/package/module/v/1.0.0'}
   );
 });
 
@@ -80,10 +109,15 @@ test('Default tag', async t => {
   await writeFile(npmrc, 'tag=');
 
   t.deepEqual(
-    await getReleaseInfo(npmrc, {name: 'module', publishConfig: {}}, {cwd, env: {}}, 'https://registry.npmjs.org/'),
+    await getReleaseInfo(
+      npmrc,
+      {name: 'module', publishConfig: {}},
+      {cwd, env: {}, nextRelease: {version: '1.0.0'}},
+      'https://registry.npmjs.org/'
+    ),
     {
       name: 'npm package (@latest dist-tag)',
-      url: 'https://www.npmjs.com/package/module',
+      url: 'https://www.npmjs.com/package/module/v/1.0.0',
     }
   );
 });

test/integration.test.js

@@ -261,7 +261,7 @@ test('Publish the package on a dist-tag', async t => {
     }
   );
 
-  t.deepEqual(result, {name: 'npm package (@next dist-tag)', url: 'https://www.npmjs.com/package/publish-tag'});
+  t.deepEqual(result, {name: 'npm package (@next dist-tag)', url: 'https://www.npmjs.com/package/publish-tag/v/1.0.0'});
   t.is((await readJson(path.resolve(cwd, 'package.json'))).version, '1.0.0');
   t.false(await pathExists(path.resolve(cwd, `${pkg.name}-1.0.0.tgz`)));
   t.is((await execa('npm', ['view', pkg.name, 'version'], {cwd, env: testEnv})).stdout, '1.0.0');