Skip to content

Commit 656d0a7

Browse files
authored
Merge pull request #204 from splitio/task/warnings
Task/warnings
2 parents 8bfeedc + d57ad7c commit 656d0a7

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

src/SplitIO/Component/Cache/SplitCache.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,9 @@ public function getSplit($splitName)
5959
public function getSplits($splitNames)
6060
{
6161
$cache = Di::getCache();
62-
$cacheItems = $cache->fetchMany(array_map('self::getCacheKeyForSplit', $splitNames));
62+
$cacheItems = $cache->fetchMany(array_map([
63+
self::class, 'getCacheKeyForSplit'
64+
], $splitNames));
6365
$toReturn = array();
6466
foreach ($cacheItems as $key => $value) {
6567
$toReturn[self::getSplitNameFromCacheKey($key)] = $value;
@@ -74,7 +76,7 @@ public function getSplitNames()
7476
{
7577
$cache = Di::getCache();
7678
$splitKeys = $cache->getKeys(self::getCacheKeySearchPattern());
77-
return array_map('self::getSplitNameFromCacheKey', $splitKeys);
79+
return array_map([self::class, 'getSplitNameFromCacheKey'], $splitKeys);
7880
}
7981

8082
/**

src/SplitIO/Grammar/Condition/Matcher/ContainsString.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
class ContainsString extends AbstractMatcher
88
{
9-
protected $ContainsStringMatcherData = null;
9+
private $containsStringMatcherData = null;
1010

1111
public function __construct($data, $negate = false, $attribute = null)
1212
{

src/SplitIO/Sdk/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function __construct($options = array())
5050
* @param $featureFlag
5151
* @param $treatment
5252
* @param string $label
53-
* @param null $time
53+
* @param $time
5454
* @param int $changeNumber
5555
* @param string $bucketingKey
5656
*

src/SplitIO/Sdk/Events/EventDTO.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ class EventDTO
1010
private $eventTypeId;
1111
private $value;
1212
private $timestamp;
13+
private $properties;
1314

1415
public function __construct($key, $trafficTypeName, $eventTypeId, $value, $properties)
1516
{

src/SplitIO/Sdk/Manager/SplitManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public function splits()
2222
{
2323
$cache = new SplitCache();
2424
$rawSplits = $cache->getAllSplits();
25-
return array_map('self::parseSplitView', $rawSplits);
25+
return array_map([self::class, 'parseSplitView'], $rawSplits);
2626
}
2727

2828
/**

0 commit comments

Comments
 (0)