Skip to content

Commit 4ea438a

Browse files
authored
Merge pull request #759 from topcoder-platform/onboarding-minor-fixes
2 parents e8e14cb + d15c710 commit 4ea438a

File tree

2 files changed

+9
-3
lines changed
  • src
    • apps/onboarding/src/components/modal-add-work
    • libs/ui/lib/components/form/form-groups/form-input/input-select

2 files changed

+9
-3
lines changed

src/apps/onboarding/src/components/modal-add-work/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ const ModalAddWork: FC<ModalAddWorkProps> = (props: ModalAddWorkProps) => {
141141
</div>
142142
<div className='full-width'>
143143
<InputSelect
144-
tabIndex={1}
144+
tabIndex={0}
145145
options={industryOptions}
146146
value={workInfo.industry}
147147
onChange={function onChange(event: any) {

src/libs/ui/lib/components/form/form-groups/form-input/input-select/InputSelect.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,19 @@ const InputSelect: FC<InputSelectProps> = (props: InputSelectProps) => {
7878
hideInlineErrors={props.hideInlineErrors}
7979
ref={triggerRef}
8080
>
81-
<div className={styles.selected} onClick={toggleIfNotDisabled}>
81+
<button
82+
tabIndex={props.tabIndex}
83+
className={styles.selected}
84+
onClick={toggleIfNotDisabled}
85+
type='button'
86+
disabled={!!props.disabled}
87+
>
8288
<span className='body-small'>{selectedOption ? label(selectedOption) : ''}</span>
8389
<span className='body-small'>{!selectedOption && !!props.placeholder ? props.placeholder : ''}</span>
8490
<span className={styles['selected-icon']}>
8591
<IconOutline.ChevronDownIcon />
8692
</span>
87-
</div>
93+
</button>
8894

8995
<div className={styles['menu-wrap']}>
9096
{menuIsVisible && (

0 commit comments

Comments
 (0)