Supporting export default handler for API routes?

[hamlim]

Excited to see that API routes are now stable in waku!

One of the early minor frictions that I ran into with using them was that I needed to export the named method handlers explicitly, instead of exporting a single default handler.

For example:

// within src/pages/api/contacts.ts

export default async function handler(request: Request): Promise<Response> {
  // Called for any type of request method
  // developer can choose to use a single export
  // and `switch` on `request.method`
  // or, use the individual named exports for handling different methods
}

This can be accomplished today, with a bit of manual work:

export default async function handler() { /* ... */ }

export {
  handler as GET,
  handler as POST,
  // ...
};

[tylersayshi]

I see no reason not to handle both.

We'd need a precedence or error when named is also used. I think I'd lean to just a documented precedence order of named overrides default.

[tylersayshi]

actually this would need to a createPages change. I was wrong. This line shows where we pass an object of method handlers. We would need to add some sort of "all methods" handler to the createApi type.

https://github.com/wakujs/waku/blob/main/packages/waku/src/router/create-pages.ts#L187

[dai-shi]

Is it going to be 'all' or something? Only "dynamic" api route is supported, correct?

[tylersayshi]

Is it going to be 'all' or something?

all or default, yea.

Only "dynamic" api route is supported, correct?

yes

[tylersayshi]

'all' probably makes the most sense

[dai-shi]

I'm not sure how the implementation is going to be, but I'm fine with the api with 'all'. I think the bigger issue is documentation.