Expose foreign key constraint options

Author: kvch

docs/operations/create_constraint.mdx

@@ -22,6 +22,9 @@ Required fields: `name`, `table`, `type`, `up`, `down`.
       "table": "name of referenced table",
       "columns": "[names of referenced columns]",
       "on_delete": "ON DELETE behaviour, can be CASCADE, SET NULL, RESTRICT, or NO ACTION. Default is NO ACTION",
+      "on_delete_set_columns": ["list of FKs to set", "in on delete operation on SET NULL or SET DEFAULT"],
+      "on_update": "ON UPDATE behaviour, can be CASCADE, SET NULL, RESTRICT, or NO ACTION. Default is NO ACTION",
+      "match_type": "match type, can be SIMPLE or FULL. Default is SIMPLE"
     },
     "up": {
       "column1": "up SQL expressions for each column covered by the constraint",

docs/operations/create_table.mdx

@@ -42,6 +42,8 @@ Each `column` is defined as:
     "table": "name of referenced table",
     "column": "name of referenced column",
     "on_delete": "ON DELETE behaviour, can be CASCADE, SET NULL, SET DEFAULT, RESTRICT, or NO ACTION. Default is NO ACTION",
+    "on_update": "ON UPDATE behaviour, can be CASCADE, SET NULL, RESTRICT, or NO ACTION. Default is NO ACTION",
+    "match_type": "match type, can be SIMPLE or FULL. Default is SIMPLE"
   }
 },
 ```

pkg/migrations/op_add_column.go

@@ -314,16 +314,14 @@ func (w ColumnSQLWriter) Write(col Column) (string, error) {
 	}
 
 	if col.References != nil {
-		onDelete := string(ForeignKeyActionNOACTION)
-		if col.References.OnDelete != "" {
-			onDelete = strings.ToUpper(string(col.References.OnDelete))
-		}
-
-		sql += fmt.Sprintf(" CONSTRAINT %s REFERENCES %s(%s) ON DELETE %s",
-			pq.QuoteIdentifier(col.References.Name),
-			pq.QuoteIdentifier(col.References.Table),
-			pq.QuoteIdentifier(col.References.Column),
-			onDelete)
+		writer := &ConstraintSQLWriter{Name: col.References.Name}
+		sql += " " + writer.WriteForeignKey(
+			col.References.Table,
+			[]string{col.References.Column},
+			col.References.OnDelete,
+			col.References.OnUpdate,
+			nil,
+			col.References.MatchType)
 	}
 	if col.Check != nil {
 		sql += fmt.Sprintf(" CONSTRAINT %s CHECK (%s)",

pkg/migrations/op_create_constraint.go

@@ -68,11 +68,7 @@ func (o *OpCreateConstraint) Start(ctx context.Context, conn db.DB, latestSchema
 
 	switch o.Type {
 	case OpCreateConstraintTypeUnique:
-		temporaryColumnNames := make([]string, len(o.Columns))
-		for i, col := range o.Columns {
-			temporaryColumnNames[i] = TemporaryName(col)
-		}
-		return table, createUniqueIndexConcurrently(ctx, conn, s.Name, o.Name, o.Table, temporaryColumnNames)
+		return table, createUniqueIndexConcurrently(ctx, conn, s.Name, o.Name, o.Table, temporaryNames(o.Columns))
 	case OpCreateConstraintTypeCheck:
 		return table, o.addCheckConstraint(ctx, conn)
 	case OpCreateConstraintTypeForeignKey:
@@ -248,24 +244,35 @@ func (o *OpCreateConstraint) addCheckConstraint(ctx context.Context, conn db.DB)
 }
 
 func (o *OpCreateConstraint) addForeignKeyConstraint(ctx context.Context, conn db.DB) error {
-	onDelete := "NO ACTION"
-	if o.References.OnDelete != "" {
-		onDelete = strings.ToUpper(string(o.References.OnDelete))
+	sql := fmt.Sprintf("ALTER TABLE %s ADD ", pq.QuoteIdentifier(o.Table))
+
+	writer := &ConstraintSQLWriter{
+		Name:           o.Name,
+		Columns:        temoraryNames(o.Columns),
+		SkipValidation: true,
 	}
+	sql += writer.WriteForeignKey(
+		o.References.Table,
+		o.References.Columns,
+		o.References.OnDelete,
+		o.References.OnUpdate,
+		o.References.OnDeleteSetColumns,
+		o.References.MatchType,
+	)
 
-	_, err := conn.ExecContext(ctx,
-		fmt.Sprintf("ALTER TABLE %s ADD CONSTRAINT %s FOREIGN KEY (%s) REFERENCES %s (%s) ON DELETE %s NOT VALID",
-			pq.QuoteIdentifier(o.Table),
-			pq.QuoteIdentifier(o.Name),
-			strings.Join(quotedTemporaryNames(o.Columns), ","),
-			pq.QuoteIdentifier(o.References.Table),
-			strings.Join(quoteColumnNames(o.References.Columns), ","),
-			onDelete,
-		))
+	_, err := conn.ExecContext(ctx, sql)
 
 	return err
 }
 
+func temporaryNames(columns []string) []string {
+	names := make([]string, len(columns))
+	for i, col := range columns {
+		names[i] = TemporaryName(col)
+	}
+	return names
+}
+
 func quotedTemporaryNames(columns []string) []string {
 	names := make([]string, len(columns))
 	for i, col := range columns {

pkg/migrations/op_set_fk.go

@@ -5,7 +5,6 @@ package migrations
 import (
 	"context"
 	"fmt"
-	"strings"
 
 	"github.com/lib/pq"
 
@@ -89,20 +88,20 @@ func (o *OpSetForeignKey) addForeignKeyConstraint(ctx context.Context, conn db.D
 	referencedTable := s.GetTable(o.References.Table)
 	referencedColumn := referencedTable.GetColumn(o.References.Column)
 
-	onDelete := "NO ACTION"
-	if o.References.OnDelete != "" {
-		onDelete = strings.ToUpper(string(o.References.OnDelete))
+	sql := fmt.Sprintf("ALTER TABLE %s ADD ", pq.QuoteIdentifier(table.Name))
+	writer := &ConstraintSQLWriter{
+		Name:           o.References.Name,
+		Columns:        []string{column.Name},
+		SkipValidation: true,
 	}
-
-	_, err := conn.ExecContext(ctx,
-		fmt.Sprintf("ALTER TABLE %s ADD CONSTRAINT %s FOREIGN KEY (%s) REFERENCES %s (%s) ON DELETE %s NOT VALID",
-			pq.QuoteIdentifier(table.Name),
-			pq.QuoteIdentifier(o.References.Name),
-			pq.QuoteIdentifier(column.Name),
-			pq.QuoteIdentifier(referencedTable.Name),
-			pq.QuoteIdentifier(referencedColumn.Name),
-			onDelete,
-		))
-
+	sql += writer.WriteForeignKey(
+		referencedTable.Name,
+		[]string{referencedColumn.Name},
+		o.References.OnDelete,
+		o.References.OnUpdate,
+		nil,
+		o.References.MatchType)
+
+	_, err := conn.ExecContext(ctx, sql)
 	return err
 }