Rename and move test variables relating to sql2pgroll (#512)

* Rename the test variables to match their operation type.
* Rename files to match the operation type.

Part of #504

Author: andrew-farries

pkg/sql2pgroll/alter_table_test.go

@@ -21,27 +21,27 @@ func TestConvertAlterTableStatements(t *testing.T) {
 	}{
 		{
 			sql:        "ALTER TABLE foo ALTER COLUMN a SET NOT NULL",
-			expectedOp: expect.AlterTableOp1,
+			expectedOp: expect.AlterColumnOp1,
 		},
 		{
 			sql:        "ALTER TABLE foo ALTER COLUMN a DROP NOT NULL",
-			expectedOp: expect.AlterTableOp2,
+			expectedOp: expect.AlterColumnOp2,
 		},
 		{
 			sql:        "ALTER TABLE foo ALTER COLUMN a SET DATA TYPE text",
-			expectedOp: expect.AlterTableOp3,
+			expectedOp: expect.AlterColumnOp3,
 		},
 		{
 			sql:        "ALTER TABLE foo ALTER COLUMN a TYPE text",
-			expectedOp: expect.AlterTableOp3,
+			expectedOp: expect.AlterColumnOp3,
 		},
 		{
 			sql:        "ALTER TABLE foo ADD CONSTRAINT bar UNIQUE (a)",
-			expectedOp: expect.AlterTableOp4,
+			expectedOp: expect.CreateConstraintOp1,
 		},
 		{
 			sql:        "ALTER TABLE foo ADD CONSTRAINT bar UNIQUE (a, b)",
-			expectedOp: expect.AlterTableOp5,
+			expectedOp: expect.CreateConstraintOp2,
 		},
 	}
 

pkg/sql2pgroll/expect/alter_column.go

@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: Apache-2.0
+
+package expect
+
+import (
+	"github.com/xataio/pgroll/pkg/migrations"
+	"github.com/xataio/pgroll/pkg/sql2pgroll"
+)
+
+var AlterColumnOp1 = &migrations.OpAlterColumn{
+	Table:    "foo",
+	Column:   "a",
+	Nullable: ptr(false),
+	Up:       sql2pgroll.PlaceHolderSQL,
+	Down:     sql2pgroll.PlaceHolderSQL,
+}
+
+var AlterColumnOp2 = &migrations.OpAlterColumn{
+	Table:    "foo",
+	Column:   "a",
+	Nullable: ptr(true),
+	Up:       sql2pgroll.PlaceHolderSQL,
+	Down:     sql2pgroll.PlaceHolderSQL,
+}
+
+var AlterColumnOp3 = &migrations.OpAlterColumn{
+	Table:  "foo",
+	Column: "a",
+	Type:   ptr("text"),
+	Up:     sql2pgroll.PlaceHolderSQL,
+	Down:   sql2pgroll.PlaceHolderSQL,
+}
+
+var AlterColumnOp4 = &migrations.OpAlterColumn{
+	Table:  "foo",
+	Column: "a",
+	Name:   ptr("b"),
+}
+
+func ptr[T any](v T) *T {
+	return &v
+}

pkg/sql2pgroll/expect/alter_table.go

@@ -0,0 +1,32 @@
+// SPDX-License-Identifier: Apache-2.0
+
+package expect
+
+import (
+	"github.com/xataio/pgroll/pkg/migrations"
+	"github.com/xataio/pgroll/pkg/sql2pgroll"
+)
+
+var CreateConstraintOp1 = &migrations.OpCreateConstraint{
+	Type:    migrations.OpCreateConstraintTypeUnique,
+	Name:    "bar",
+	Table:   "foo",
+	Columns: []string{"a"},
+	Down:    map[string]string{"a": sql2pgroll.PlaceHolderSQL},
+	Up:      map[string]string{"a": sql2pgroll.PlaceHolderSQL},
+}
+
+var CreateConstraintOp2 = &migrations.OpCreateConstraint{
+	Type:    migrations.OpCreateConstraintTypeUnique,
+	Name:    "bar",
+	Table:   "foo",
+	Columns: []string{"a", "b"},
+	Down: map[string]string{
+		"a": sql2pgroll.PlaceHolderSQL,
+		"b": sql2pgroll.PlaceHolderSQL,
+	},
+	Up: map[string]string{
+		"a": sql2pgroll.PlaceHolderSQL,
+		"b": sql2pgroll.PlaceHolderSQL,
+	},
+}

pkg/sql2pgroll/expect/create_constraint.go

@@ -21,11 +21,11 @@ func TestConvertRenameColumnStatements(t *testing.T) {
 	}{
 		{
 			sql:        "ALTER TABLE foo RENAME COLUMN a TO b",
-			expectedOp: expect.AlterTableOp6,
+			expectedOp: expect.AlterColumnOp4,
 		},
 		{
 			sql:        "ALTER TABLE foo RENAME a TO b",
-			expectedOp: expect.AlterTableOp6,
+			expectedOp: expect.AlterColumnOp4,
 		},
 	}