Skip to content

Commit 55ef063

Browse files
Add a testcase for schema qualified CREATE TABLE
Ensure that schema qualified `CREATE TABLE` statements are correctly converted to a `migrations.OpCreateTable` operation.
1 parent f54ea25 commit 55ef063

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

pkg/sql2pgroll/create_table.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func convertCreateStmt(stmt *pgq.CreateStmt) (migrations.Operations, error) {
4141

4242
return migrations.Operations{
4343
&migrations.OpCreateTable{
44-
Name: stmt.Relation.GetRelname(),
44+
Name: getQualifiedRelationName(stmt.GetRelation()),
4545
Columns: columns,
4646
},
4747
}, nil

pkg/sql2pgroll/create_table_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ func TestConvertCreateTableStatements(t *testing.T) {
2424
sql: "CREATE TABLE foo(a int)",
2525
expectedOp: expect.CreateTableOp1,
2626
},
27+
{
28+
sql: "CREATE TABLE schema.foo(a int)",
29+
expectedOp: expect.CreateTableOp17,
30+
},
2731
{
2832
sql: "CREATE TABLE foo(a int NULL)",
2933
expectedOp: expect.CreateTableOp1,

pkg/sql2pgroll/expect/create_table.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,3 +214,14 @@ var CreateTableOp16 = &migrations.OpCreateTable{
214214
},
215215
},
216216
}
217+
218+
var CreateTableOp17 = &migrations.OpCreateTable{
219+
Name: "schema.foo",
220+
Columns: []migrations.Column{
221+
{
222+
Name: "a",
223+
Type: "int",
224+
Nullable: true,
225+
},
226+
},
227+
}

0 commit comments

Comments
 (0)