Bump golangci-lint to v2 (#904)

Bump `golangci-lint` to `v2`.

Required rewriting `.golangci.yml` which was automated with
`golangci-lint migrate`
[[docs](https://golangci-lint.run/product/migration-guide/)].

Fix one linter issue that was uncovered by the upgrade.

Author: andrew-farries

.github/workflows/build.yml

@@ -81,18 +81,10 @@ jobs:
         cache: false
 
     - name: golangci-lint
-      uses: golangci/golangci-lint-action@v4
+      uses: golangci/golangci-lint-action@v8
       with:
-        # Require: The version of golangci-lint to use.
-        # When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
-        # When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
-        version: v1.64.5
-
-        # Optional: golangci-lint command line arguments.
-        #
-        # Note: By default, the `.golangci.yml` file should be at the root of the repository.
-        # The location of the configuration file can be changed by using `--config=`
-        args: --timeout=30m --out-format=colored-line-number --config=.golangci.yml
+        version: v2.1
+        args: --timeout=30m --config=.golangci.yml
 
   format:
     name: format

.golangci.yml

@@ -1,77 +1,74 @@
-goVersion: &goVersion "1.24"
-
-run:
-  go: *goVersion
-  timeout: 5m
-
+version: "2"
 linters:
-  disable-all: true
-  # Enable specific linter
-  # https://golangci-lint.run/usage/linters/#enabled-by-default-linters
+  default: none
   enable:
-    - errorlint
     - copyloopvar
+    - errorlint
     - forcetypeassert
     - goconst
     - gocritic
-    - gofumpt
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - makezero
     - misspell
     - nakedret
     - nolintlint
     - prealloc
-    - prealloc
     - staticcheck
-    - stylecheck
     - unused
-
-linters-settings:
-  errorlint:
-    errorf: true
-
-  gomodguard:
-    blocked:
-      # List of blocked modules.
-      modules:
-        # Blocked module.
-        - github.com/pkg/errors:
-            # Recommended modules that should be used instead. (Optional)
-            recommendations:
-              - errors
-              - fmt
-            reason: "This package is deprecated, use `fmt.Errorf` with `%w` instead"
-
-  goconst:
-    ignore-tests: true
-    numbers: true
-
-  gocritic:
-    disabled-checks:
-      - exitAfterDefer
-      - ifElseChain
-      - commentFormatting
-
-  gofumpt:
-    module-path: "pgroll"
-    extra-rules: false
-
-  staticcheck:
-    checks: ["all"]
-
-  stylecheck:
-    checks: ["all", "-ST1000", "-ST1005"]
-
-  unused:
-    go: *goVersion
-
-  makezero:
-    always: false
-
-  gosec:
-    exclude-generated: true
-    severity: low
-    includes: []
+  settings:
+    errorlint:
+      errorf: true
+    goconst:
+      numbers: true
+    gocritic:
+      disabled-checks:
+        - exitAfterDefer
+        - ifElseChain
+        - commentFormatting
+    gomodguard:
+      blocked:
+        modules:
+          - github.com/pkg/errors:
+              recommendations:
+                - errors
+                - fmt
+              reason: This package is deprecated, use `fmt.Errorf` with `%w` instead
+    gosec:
+      severity: low
+    makezero:
+      always: false
+    staticcheck:
+      checks:
+        - all
+        - -ST1000
+        - -ST1005
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - goconst
+        path: (.+)_test\.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofumpt
+  settings:
+    gofumpt:
+      module-path: pgroll
+      extra-rules: false
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

pkg/sql2pgroll/create_index.go

@@ -90,10 +90,7 @@ func convertCreateIndexStmt(stmt *pgq.IndexStmt) (migrations.Operations, error)
 	}
 
 	// Get index uniqueness
-	unique := false
-	if stmt.GetUnique() {
-		unique = true
-	}
+	unique := stmt.GetUnique()
 
 	// Deparse WHERE clause
 	var predicate string