Merge branch 'release/1.0.0'

yoanm · yoanm · commit 672ca83a7571 · 2020-03-28T17:28:50.000+01:00
diff --git a/.gitignore b/.gitignore
@@ -4,3 +4,6 @@ build
 composer.lock
 
 features/demo_app/var
+
+#Phpunit
+.phpunit.result.cache
diff --git a/.scrutinizer.yml b/.scrutinizer.yml
@@ -46,7 +46,7 @@ build:
             COVERAGE_OUTPUT_STYLE: 'clover'
             COVERAGE_CLOVER_FILE_PATH: 'build/coverage/clover.xml'
         php:
-            version: "7.1"
+            version: "7.3"
         timezone: UTC
         postgresql: false
         redis: false
diff --git a/.travis.yml b/.travis.yml
@@ -1,7 +1,6 @@
 language: php
 
 php:
-  - '7.1'
   - '7.2'
   - '7.3'
   - '7.4'
@@ -13,8 +12,8 @@ env:
     - PHPCS_REPORT_STYLE: 'full'
     - COMPOSER_OPTIONS: '--optimize-autoloader'
   jobs:
-    - SYMFONY_VERSION: '~3.0'
     - SYMFONY_VERSION: '~4.0'
+    - SYMFONY_VERSION: '~5.0'
 
 jobs:
   fast_finish: true
@@ -24,7 +23,7 @@ before_install:
   - phpenv config-rm xdebug.ini || true
 
 install:
-  - composer require symfony/http-kernel:$SYMFONY_VERSION symfony/dependency-injection:$SYMFONY_VERSION symfony/config:$SYMFONY_VERSION symfony/routing:$SYMFONY_VERSION
+  - composer require symfony/http-kernel:$SYMFONY_VERSION symfony/dependency-injection:$SYMFONY_VERSION symfony/config:$SYMFONY_VERSION symfony/routing:$SYMFONY_VERSION symfony/event-dispatcher:$SYMFONY_VERSION
   - make build
 script:
   - make test-technical
diff --git a/README.md b/README.md
@@ -3,14 +3,18 @@
 
 [![Scrutinizer Build Status](https://img.shields.io/scrutinizer/build/g/yoanm/symfony-jsonrpc-http-server-swagger-doc.svg?label=Scrutinizer&logo=scrutinizer)](https://scrutinizer-ci.com/g/yoanm/symfony-jsonrpc-http-server-swagger-doc/build-status/master) [![Scrutinizer Code Quality](https://img.shields.io/scrutinizer/g/yoanm/symfony-jsonrpc-http-server-swagger-doc/master.svg?logo=scrutinizer)](https://scrutinizer-ci.com/g/yoanm/symfony-jsonrpc-http-server-swagger-doc/?branch=master) [![Code Coverage](https://img.shields.io/scrutinizer/coverage/g/yoanm/symfony-jsonrpc-http-server-swagger-doc/master.svg?logo=scrutinizer)](https://scrutinizer-ci.com/g/yoanm/symfony-jsonrpc-http-server-swagger-doc/?branch=master)
 
-[![Travis Build Status](https://img.shields.io/travis/com/yoanm/symfony-jsonrpc-http-server-swagger-doc/master.svg?label=Travis&logo=travis)](https://travis-ci.com/yoanm/symfony-jsonrpc-http-server-swagger-doc) <!-- NOT WORKING WITH travis-ci.com [![Travis PHP versions](https://img.shields.io/travis/php-v/yoanm/symfony-jsonrpc-http-server-swagger-doc.svg?logo=travis)](https://php.net/) --> [![Travis Symfony Versions](https://img.shields.io/badge/Symfony-v3%20%2F%20v4-8892BF.svg?logo=travis)](https://symfony.com/)
+[![Travis Build Status](https://img.shields.io/travis/com/yoanm/symfony-jsonrpc-http-server-swagger-doc/master.svg?label=Travis&logo=travis)](https://travis-ci.com/yoanm/symfony-jsonrpc-http-server-swagger-doc) <!-- NOT WORKING WITH travis-ci.com [![Travis PHP versions](https://img.shields.io/travis/php-v/yoanm/symfony-jsonrpc-http-server-swagger-doc.svg?logo=travis)](https://php.net/) --> [![Travis Symfony Versions](https://img.shields.io/badge/Symfony-v4%20%2F%20v5-8892BF.svg?logo=travis)](https://symfony.com/)
 
 [![Latest Stable Version](https://img.shields.io/packagist/v/yoanm/symfony-jsonrpc-http-server-swagger-doc.svg)](https://packagist.org/packages/yoanm/symfony-jsonrpc-http-server-swagger-doc) [![Packagist PHP version](https://img.shields.io/packagist/php-v/yoanm/symfony-jsonrpc-http-server-swagger-doc.svg)](https://packagist.org/packages/yoanm/symfony-jsonrpc-http-server-swagger-doc)
 
 Symfony bundle for easy JSON-RPC server Swagger 2.0 documentation
 
 Symfony bundle for [yoanm/jsonrpc-http-server-swagger-doc-sdk](https://github.com/yoanm/php-jsonrpc-http-server-swagger-doc-sdk)
 
+## Versions
+- Symfony v3/4 - PHP >=7.1 : `^v0.X`
+- Symfony v4/5 - PHP >=7.2 : `^v1.0`
+
 ## How to use
 
 Once configured, your project is ready to handle HTTP `GET` request on `/doc/swagger.json` endpoint. Result will be a swagger compatible file.
diff --git a/composer.json b/composer.json
@@ -32,23 +32,24 @@
     "yoanm/symfony-jsonrpc-http-server": "Symfony Bundle to convert an HTTP json-rpc request into HTTP json-rpc response"
   },
   "require": {
-    "php": ">=7.1",
-    "symfony/config": "^3.0 || ^4.0",
-    "symfony/dependency-injection": "^3.0 || ^4.0",
-    "symfony/event-dispatcher-contracts": "^1.0",
-    "symfony/http-kernel": "^3.0 || ^4.0",
+    "php": ">=7.2",
+    "symfony/config": "^4.0 || ^5.0",
+    "symfony/dependency-injection": "^4.0 || ^5.0",
+    "symfony/event-dispatcher-contracts": "^1.0 || ^2.0",
+    "symfony/http-kernel": "^4.0 || ^5.0",
     "yoanm/jsonrpc-http-server-swagger-doc-sdk": "^0.2",
     "yoanm/jsonrpc-server-doc-sdk": "^0.2",
-    "yoanm/symfony-jsonrpc-http-server-doc": "^0.2"
+    "yoanm/symfony-jsonrpc-http-server-doc": "^1.0"
   },
   "require-dev": {
     "behat/behat": "~3.0",
     "matthiasnoback/symfony-config-test": "^3.0 || ^4.0",
     "matthiasnoback/symfony-dependency-injection-test": "^3.0 || ^4.0",
     "phpunit/phpunit": "^7.0 || ^8.0",
     "squizlabs/php_codesniffer": "3.*",
-    "symfony/framework-bundle": "^3.0 || ^4.0",
-    "symfony/routing": "^3.0 || ^4.0",
+    "symfony/event-dispatcher": "^4.0 || ^5.0",
+    "symfony/framework-bundle": "^4.0 || ^5.0",
+    "symfony/routing": "^4.0 || ^5.0",
     "yoanm/php-unit-extended": "~1.0"
   }
 }
diff --git a/src/Provider/DocProvider.php b/src/Provider/DocProvider.php
@@ -47,7 +47,7 @@ public function getDoc($host = null) : array
         $swaggerDoc = $this->docNormalizer->normalize($rawDoc);
 
         $event = new SwaggerDocCreatedEvent($swaggerDoc, $rawDoc);
-        $this->dispatcher->dispatch($event::EVENT_NAME, $event);
+        $this->dispatcher->dispatch($event, $event::EVENT_NAME);
 
         return $event->getSwaggerDoc();
     }
diff --git a/tests/Functional/Provider/DocProviderTest.php b/tests/Functional/Provider/DocProviderTest.php
@@ -57,6 +57,14 @@ public function testShouldCreateHttpServerDocAndNormalizeIt()
             ->shouldBeCalled()
         ;
 
+        $this->dispatcher
+            ->dispatch(
+                Argument::type(SwaggerDocCreatedEvent::class),
+                SwaggerDocCreatedEvent::EVENT_NAME
+            )
+            ->shouldBeCalled()
+        ;
+
         $this->assertSame(
             $normalizedDoc,
             $this->provider->getDoc($host)
@@ -83,12 +91,12 @@ public function testShouldDispatchAnEvent()
 
         $this->dispatcher
             ->dispatch(
-                SwaggerDocCreatedEvent::EVENT_NAME,
                 Argument::allOf(
                     Argument::type(SwaggerDocCreatedEvent::class),
                     Argument::which('getSwaggerDoc', $normalizedDoc),
                     Argument::which('getServerDoc', $rawDoc->reveal())
-                )
+                ),
+                SwaggerDocCreatedEvent::EVENT_NAME
             )
             ->shouldBeCalled()
         ;

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function getDoc($host = null) : array`
`47`	`47`	`$swaggerDoc = $this->docNormalizer->normalize($rawDoc);`
`48`	`48`
`49`	`49`	`$event = new SwaggerDocCreatedEvent($swaggerDoc, $rawDoc);`
`50`		`- $this->dispatcher->dispatch($event::EVENT_NAME, $event);`
	`50`	`+ $this->dispatcher->dispatch($event, $event::EVENT_NAME);`
`51`	`51`
`52`	`52`	`return $event->getSwaggerDoc();`
`53`	`53`	`}`