Fix retcode and properly test shape

Author: joshmoore

generate_data/jzarr/generate_data.sh

@@ -2,8 +2,16 @@
 # https://stackoverflow.com/a/6393573/2700168
 cd "${0%/*}"
 
+set -e
+set -u
+set -x
+
 mvn clean package
-java -cp target/jzarr-1.0.0.jar zarr_implementations.jzarr.App "$@"
+java -cp target/jzarr-1.0.0.jar zarr_implementations.jzarr.App "$@" && {
+    # Workaround for: https://github.com/bcdev/jzarr/issues/25
+    find ../../data/jzarr* -name .zarray -exec sed -ibak 's/>u1/|u1/' {} \;
+} || {
+    echo jzarr failed
+    exit 2
+}
 
-# Workaround for: https://github.com/bcdev/jzarr/issues/25
-find ../../data/jzarr* -name .zarray -exec sed -ibak 's/>u1/|u1/' {} \;

generate_data/jzarr/src/main/java/zarr_implementations/jzarr/App.java

@@ -78,10 +78,10 @@ public static void main(String args[]) throws Exception {
             String dsname = args[2];
             ZarrArray verification = ZarrGroup.open(fpath).openArray(dsname);
             int[] shape = verification.getShape();
-            if (!Arrays.equals(new int[]{}, shape)) {
+            if (!Arrays.equals(SHAPE, shape)) {
                 throw new RuntimeException(String.format(
-                            "shape-mismatch expected:{} found:{}",
-                            SHAPE, shape
+                            "shape-mismatch expected:%s found:%s",
+                            Arrays.toString(SHAPE), Arrays.toString(shape)
                 ));
             }
             return;  // EARLY EXIT