DYN-9191: RecentFiles bug fix (DynamoDS#16394)

Author: zeusongit

src/DynamoCore/Configuration/PreferenceSettings.cs

@@ -1170,6 +1170,13 @@ public static PreferenceSettings Load(string filePath)
                         settings.BackupInterval = DefaultBackupInterval;
                     }
 
+                    //Do not add invalid paths for recent files list
+                    var recentFiles = settings?.RecentFiles;
+                    if (recentFiles != null)
+                    {
+                        settings.RecentFiles = recentFiles.Where(path => !string.IsNullOrEmpty(path) && DynamoUtilities.PathHelper.IsValidPath(path)).ToList();
+                    }
+
                     fs.Close(); // Release file lock
                 }
             }

src/DynamoCoreWpf/Controls/StartPage.xaml.cs

@@ -419,7 +419,11 @@ private void OnRecentFilesChanged(object sender, NotifyCollectionChangedEventArg
             }
             else if (e.Action == NotifyCollectionChangedAction.Remove)
             {
-                recentFiles.RemoveRange(e.OldStartingIndex, recentFiles.Count - e.OldStartingIndex);
+                var removedItemsCount = e.OldItems?.Count ?? 0;
+                if (recentFiles.Count > e.OldStartingIndex && recentFiles.Count >= removedItemsCount)
+                {
+                    recentFiles.RemoveRange(e.OldStartingIndex, removedItemsCount);
+                }
             }
             else
             {