Skip to content

Conversation

lijinpei2008
Copy link
Contributor

#28376

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

…ollowing cmdlet adds a BreakingChange announcement
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008 lijinpei2008 marked this pull request as ready for review August 14, 2025 09:40
@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 09:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds breaking change announcements for the Azure PowerShell ContainerInstance module as part of an upcoming refactoring effort. The primary purpose is to inform users about upcoming API changes scheduled for release 15.0.0.

  • Added breaking change attributes to the New-AzContainerGroup cmdlet
  • Updated module dependencies and configuration files
  • Corrected spelling errors in documentation

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/ContainerInstance/ContainerInstance/ChangeLog.md Added changelog entry for breaking change announcement
src/ContainerInstance/ContainerInstance/Az.ContainerInstance.psd1 Updated module dependencies and configuration
src/ContainerInstance/ContainerInstance.sln Updated solution file with new project configurations
src/ContainerInstance/ContainerInstance.Autorest/custom/New-AzContainerGroup.ps1 Added breaking change attributes to cmdlet
Documentation files Fixed spelling of "piping" in examples and docs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This command updates a container group profile using pipeing.
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'pipeing' is misspelled. It should be 'piping'.

Suggested change
This command updates a container group profile using pipeing.
This command updates a container group profile using piping.

Copilot uses AI. Check for mistakes.

@@ -26,5 +26,5 @@ AdditionalProperties : {[k, v]}
Count : 1
```

This command updates a container group using piping.
This command updates a container group using pipeing.
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'pipeing' is misspelled. It should be 'piping'.

Suggested change
This command updates a container group using pipeing.
This command updates a container group using piping.

Copilot uses AI. Check for mistakes.

@@ -72,7 +72,7 @@ AdditionalProperties : {[k, v]}
Count : 1
```

This command updates a container group profile using piping.
This command updates a container group profile using pipeing.
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'pipeing' is misspelled. It should be 'piping'.

Suggested change
This command updates a container group profile using pipeing.
This command updates a container group profile using piping.

Copilot uses AI. Check for mistakes.

@@ -58,7 +58,7 @@ AdditionalProperties : {[k, v]}
Count : 1
```

This command updates a container group using piping.
This command updates a container group using pipeing.
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'pipeing' is misspelled. It should be 'piping'.

Suggested change
This command updates a container group using pipeing.
This command updates a container group using piping.

Copilot uses AI. Check for mistakes.

@NoriZC NoriZC merged commit 34d37d5 into main Aug 18, 2025
12 checks passed
@NoriZC NoriZC deleted the jinpei/main/ContainerInstance-Announcement branch August 18, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants