[EngSys] npm update #1062
Draft
[EngSys] npm update #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeharder
commented
Apr 30, 2025
| "@azure/core-http": "^3.0.1", | ||
| "@azure/core-util": "~1.7.0", | ||
| "@azure/logger": "~1.0.4", | ||
| "@azure/core-http": "3.0.4", |
There was a problem hiding this comment.
Pin packages from azure-sdk to ensure compat with TS 3.9. Newer versions require newer TS, which includes breaking changes.
mikeharder
commented
Apr 30, 2025
| @@ -8,7 +8,7 @@ export const logger = winston.createLogger({ | |||
| winston.format.colorize({ | |||
| message: true, | |||
| }), | |||
| winston.format.printf((info) => info.message) | |||
| winston.format.printf((info) => info.message as string) | |||
There was a problem hiding this comment.
Unsure why this change was needed. Likely a new dep version requires stronger typing.
mikeharder
commented
May 1, 2025
| @@ -29,7 +29,7 @@ steps: | |||
| reportDirectory: "$(System.DefaultWorkingDirectory)/**/coverage" | |||
|
|
|||
| - script: | | |||
| echo "If this step fails, go to the published artifacts apply the patch provided to your local git repo using `git apply <file>`" | |||
| echo "If this step fails, go to the published artifacts apply the patch provided to your local git repo using 'git apply <file>'" | |||
There was a problem hiding this comment.
Unrelated fix to bash script
- upgrade in separate PR and react to breaking changes
mikeharder
commented
May 1, 2025
| @@ -39,7 +40,7 @@ | |||
| "moment": "^2.29.3", | |||
| "mustache": "^4.2.0", | |||
| "newman": "^6.0.0", | |||
| "path-to-regexp": "^6.2.1", | |||
| "path-to-regexp": "6.2.1", | |||
There was a problem hiding this comment.
Temporarily pin path-to-regexp, upgrade in separate PR and react to breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.