-
-
Notifications
You must be signed in to change notification settings - Fork 13k
vulkan-headers 1.4.321.0 (downgrade) #241891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+73
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
8c5ee91
to
f72b167
Compare
carlocab
approved these changes
Sep 15, 2025
daeho-ro
approved these changes
Sep 15, 2025
Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
CI-version-downgrade
Pass --skip-stable-version-audit to brew test-bot.
maintainer feedback
Additional maintainers' opinions may be needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?I've been trying to switch us to SDK tags but missed the timing whenever they aligned.
So just downgrading us. Due to extra
.0
, I think we should be able to upload new bottle without revision.The SDK tags are the versions upstream distribute as official releases at https://vulkan.lunarg.com/
From Repology (https://repology.org/project/vulkan-headers/versions), SDK tags are versions used by most major repositories, e.g.
While repositories on 1.4.326 include us, Chimera Linux, Exherbo, KaOS, openmamba, Ravenports and Termux.
These are better tested with compatibility with other tooling like SPIRV formulae.
Also, if we align SPIRV and Vulkan formulae, then can drop some known_good handling, e.g.
homebrew-core/Formula/v/vulkan-validationlayers.rb
Lines 41 to 51 in eab57db