Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 14, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

I've been trying to switch us to SDK tags but missed the timing whenever they aligned.

So just downgrading us. Due to extra .0, I think we should be able to upload new bottle without revision.


The SDK tags are the versions upstream distribute as official releases at https://vulkan.lunarg.com/

From Repology (https://repology.org/project/vulkan-headers/versions), SDK tags are versions used by most major repositories, e.g.

  • Alpine
  • Arch Linux
  • Fedora
  • Gentoo
  • GNU Guix
  • MacPorts
  • nixpkgs
  • OpenBSD Ports
  • Vcpkg
  • Void Linux
  • Also Debian/Ubuntu but not listed on that page.

While repositories on 1.4.326 include us, Chimera Linux, Exherbo, KaOS, openmamba, Ravenports and Termux.


These are better tested with compatibility with other tooling like SPIRV formulae.

Also, if we align SPIRV and Vulkan formulae, then can drop some known_good handling, e.g.

# https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/v#{version}/scripts/known_good.json#L32
resource "SPIRV-Headers" do
url "https://github.com/KhronosGroup/SPIRV-Headers.git",
revision: "e6d5e88c07cc66a798b668945e7fb29ec1cfee27"
end
# https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/v#{version}/scripts/known_good.json#L46
resource "SPIRV-Tools" do
url "https://github.com/KhronosGroup/SPIRV-Tools.git",
revision: "fda5a216e9d25fa2eeda73ec8436b96e395ce5d5"
end

@cho-m cho-m added the CI-version-downgrade Pass --skip-stable-version-audit to brew test-bot. label Sep 14, 2025
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 14, 2025
@cho-m cho-m removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 14, 2025
@cho-m cho-m mentioned this pull request Sep 14, 2025
36 tasks
@cho-m cho-m force-pushed the vulkan-downgrade-to-sdk branch from 8c5ee91 to f72b167 Compare September 14, 2025 22:31
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 14, 2025
@cho-m cho-m added maintainer feedback Additional maintainers' opinions may be needed and removed automerge-skip `brew pr-automerge` will skip this pull request labels Sep 15, 2025
Copy link
Contributor

:shipit: @cho-m has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 15, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit 608f5c7 Sep 15, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the vulkan-downgrade-to-sdk branch September 15, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-version-downgrade Pass --skip-stable-version-audit to brew test-bot. maintainer feedback Additional maintainers' opinions may be needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants