232 make poc to compile for linux arm64 in macos m1 #761
Conversation
| # - {os: ubuntu-22.04, image: debian10} | ||
| # - {os: ubuntu-22.04, image: debian11} | ||
| # - {os: ubuntu-22.04, image: debian12} | ||
| # - {os: ubuntu-22.04, image: rocky8} | ||
| # - {os: ubuntu-22.04, image: rocky9} | ||
| # - {os: ubuntu-22.04, image: ubuntu18.04} | ||
| # - {os: ubuntu-22.04, image: ubuntu20.04} | ||
| # - {os: ubuntu-22.04, image: ubuntu22.04} | ||
| # - {os: ubuntu-22.04, image: ubuntu24.04} |
There was a problem hiding this comment.
Uncomment these before merging.
There was a problem hiding this comment.
Done ,I also added a final commit to remove obsolete OSs
| @@ -0,0 +1,25 @@ | |||
| FROM arm64v8/ubuntu:24.04 | |||
There was a problem hiding this comment.
I would refactor this in a single file, customizing the FROM on the base image version (cf. e.g. https://github.com/KhiopsML/khiops-python/blob/e4ebcdc0e4ed9b38b61ba3e23f323a73466dde3a/packaging/docker/khiopspydev/Dockerfile.ubuntu#L4 and the CI part https://github.com/KhiopsML/khiops-python/blob/e4ebcdc0e4ed9b38b61ba3e23f323a73466dde3a/.github/workflows/dev-docker.yml#L103).
There was a problem hiding this comment.
I disagree, I think it is over-engineering. It's easier this way and there may some differences on packages depending on the architecture (e.g. a bug with mpich on arm and not on intel). We will be able to address these differences with 2 separates Dockerfiles.
bruno-at-orange
force-pushed
the
232-make-poc-to-compile-for-linux-arm64-in-macos-m1
branch
from
1b8366b to
c7cd9c7
Compare
Build ubuntu packages for ARM arcitecture