Skip to content

LinearSpringDEM bugfix #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

LinearSpringDEM bugfix #384

wants to merge 4 commits into from

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Jul 8, 2025 •
edited
Loading

Summary

  • This PR is a (bugfix and aesthetic improvement)
  • It does the following:
    • changes "effective" mass and radius definition to be consistent with literature
      • This corrects an issue Sean Wiggins identified with rolling and torsion friction coefficients 2x the expected value.
      • This also makes the implementation easy to read instead of having factors of 2 and 1/2 cancel out to same effective equations.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmpearl
LSDEM: consistency improvements with Zhang 2018. mu_r and mu_t were o…
2454691 
…ff by factor of 2, other edits are aesthetic
@jmpearl jmpearl marked this pull request as draft July 8, 2025 14:35
@jmpearl jmpearl requested a review from jmikeowen September 16, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen Awaiting requested review from jmikeowen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmpearl