monitor converting merkle tree syncing #17725
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
force-pushed
the
lyh/monitor-converting-db-synced
branch
from
606695c to
88eb10c
Compare
|
Actually, it might be a better idea if we don't have this test code injected everywhere in this code. Another abstraction that tracks monitoring along giving a name to the ledgers, would've been better, I think. |
|
I think it's probably better to do a "better" monitor when we are actually sure what do we want, I think. For now this should be good enough? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements converting merkle tree level sync monitoring. An exception would be thrown if the monitor figures that 2 ledgers are out of synced.