Generate a full hard fork config #17735
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
reviewed
Sep 8, 2025
| | Error e -> | ||
| eprintf "Failed to request hardfork config generation: %s\n" | ||
| (Error.to_string_hum e) ; | ||
| exit 17 |
There was a problem hiding this comment.
Do we have a general policy for using exit code?
There was a problem hiding this comment.
No, I don't think so. It's also used when a client gets an error at a graphql endpoint. Some other parts of the code use exit 15 for client connection issues. The exit codes are not well organized.
The faster hard fork config generation method will involve applying the diffs from a ledger mask branch onto a copy of its root. For that reason it will be convenient to keep around more information about those ledgers, so they can be migrated properly. The next epoch ledger is most relevant for the upcoming hardfork; it could be 1. its own root, which should be checkpointed directly, or 2. an uncommitted ledger in the transition frontier, which should have its accumulated diff harvested and applied to the root snarked ledger
cjjdespres
force-pushed
the
cjjdespres/fast-fork-config-dump
branch
from
fc6de47 to
85e01d0
Compare
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR for generating a full hard fork config. The first commit 7f62428 was cherry-picked from #17722, which will eventually be merged.
The code contains some duplication and doesn't handle genesis epoch ledger snapshots yet. The dump also doesn't activate automatically - I've included a test RPC command to generate the hard fork config in a specified directory.