-
Notifications
You must be signed in to change notification settings - Fork 584
[HF][Upgrade Script] Upgrade script for single archive node test #17769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
!ci-build-me |
72c4473
to
0c39a61
Compare
!ci-build-me |
Invoking
Could you give some instructions how should I test locally? Thanks :) |
|
I'm running on a freshly created postgresdb. I've ran
before the test. |
src/test/mina_automation/utils.ml
Outdated
|
||
let possible_locations ~file possible_locations = | ||
let exists_at_path folder file = | ||
match Sys.file_exists (folder ^ "/" ^ file) with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: replace ^ "/" ^
with ^/
@glyh please rerun test without -v to see exception |
d3a9f26
to
fac3db1
Compare
!ci-build-me |
!ci-build-me |
!ci-bypass-changelog |
Added Upgrade script test for single archive node. This test is meant to ensure that mesa upgrade script applied on schema on which 3.X.X archive node is operating won't cause any issues. Test steps:
I also applied small refactoring to solve to issues. First one was a duplication between upgrade and precomputed_blocks test. They use similar flow so common parts were moved to new module.
Another problem was how to deal with local/ci configuration. Usually local development environment does not have installed archive debian, therefore we need to fetch upgrade script from src/app/archive/create_schema.sql while on ci we operates on archive from debian package. It installs scripts into /etc/mina/archive. I introduced simple function to provide script path based on possible locations + path env var/