-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(module:statistic): correct DOM structure and naming #9330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(module:statistic): correct DOM structure and naming #9330
Conversation
e5e1edb
to
cb35f39
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9330 +/- ##
==========================================
- Coverage 92.12% 92.08% -0.05%
==========================================
Files 561 561
Lines 19631 19631
Branches 3107 3000 -107
==========================================
- Hits 18086 18078 -8
- Misses 1206 1214 +8
Partials 339 339 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@HyperLife1119 WDYT to create a little schematics for this breaking change? |
Are you interested in this? This component is only used internally, although it exports a public API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for the futur, i could help on it :), as this component is only for internal use maybe it's not necessary to create a schematics only for an internal use |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Rename NzStatisticNumber to NzStatisticContentValue.
Does this PR introduce a breaking change?
Other information