Skip to content

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Aug 18, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

image

What is the new behavior?

  • image
  • Rename NzStatisticNumber to NzStatisticContentValue.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@HyperLife1119 HyperLife1119 force-pushed the refactor/statistic-content-value branch from e5e1edb to cb35f39 Compare August 18, 2025 02:48
@HyperLife1119 HyperLife1119 added 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: unreviewed Component: Statistic PR: target-major labels Aug 18, 2025
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.08%. Comparing base (b0a4287) to head (cb35f39).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9330      +/-   ##
==========================================
- Coverage   92.12%   92.08%   -0.05%     
==========================================
  Files         561      561              
  Lines       19631    19631              
  Branches     3107     3000     -107     
==========================================
- Hits        18086    18078       -8     
- Misses       1206     1214       +8     
  Partials      339      339              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54
Copy link
Collaborator

@HyperLife1119 WDYT to create a little schematics for this breaking change?

@HyperLife1119
Copy link
Collaborator Author

@HyperLife1119 WDYT to create a little schematics for this breaking change?

Are you interested in this? This component is only used internally, although it exports a public API.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54
Copy link
Collaborator

Are you interested in this? This component is only used internally, although it exports a public API.

for the futur, i could help on it :), as this component is only for internal use maybe it's not necessary to create a schematics only for an internal use

@Laffery Laffery added this to the v21 milestone Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes Component: Statistic PR: reviewed-approved PR: target-major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants