-
Notifications
You must be signed in to change notification settings - Fork 20
update the module life cycle doc #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the module life cycle documentation to reflect recent discussions, adding requirements for external expert input and clarifying the Beta stage behavior.
- Require external expert input and highlight modules lacking it with a caution banner
- Refine phrasing in the Implementation and Beta sections for clarity
Does this imply that if the beta banner is removed, there can be no added tools, or param parsing fixes? |
Honestly, I am not sure how to handle this. |
I would say the approval is rather for the conceptual benchmark proposed in the module, not the implementation of parameter and tool output parsing. |
I guess that the beta banner and the stamp of external expert approval (although the point is more to have the discussion, I would not use "approval") are two independent things. |
Maybe we should start a discussion on when to remove the beta banner? 😅 |
I agree with @enryH that the BETA flag should not really reflect the implementation of param or tool parsing, since indeed there might always be errors we want to fix and eternal BETA flags are indeed not desirable. If we want to keep the BETA banner and external expert approval banner separate, I do like the idea of the beta banner being a time-dependent thing, like you write in the docs. That there is a certain amount of time needed that is used to collect feedback and bug reports. Altough this is still a bit vague, of course |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
I updated the module life cycle document to correspond to our discussions last week.
Not sure it is all good.
Feel free to amend/comment.