Skip to content

#50 enable export of timezone from metadata in to-mos #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: development
Choose a base branch
from

Conversation

FWuellhorst
Copy link
Collaborator

@FWuellhorst FWuellhorst commented Jul 9, 2025

This closes #50.

Todos:

  • Check correctnes
  • Add test
  • add epw output and possibly others

Copy link
Contributor

@MartinRaetz MartinRaetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @FWuellhorst.

Can you confirm that the tests will cover sufficiently the new feature? Since its the new default the regression tests should be running on the new default.

@MartinRaetz MartinRaetz changed the base branch from main to development July 11, 2025 12:43
@FWuellhorst
Copy link
Collaborator Author

@MartinRaetz: I checked locally in Dymola for a single test and the feature works well for Modelica.

@TobiasSpratte : Can you check the with E+ if the exported .epw with the timezone also works as expected, especially in combination with SPAWN and mos. I don't know how to access the weather results from E+ in Spawn.

Future development options:

  • Add a simple test model to at least check created mos files locally for different tilts and orientations, see screenshot
image
  • Make all tests check both utc and export with timezone
  • add an example with a different timezone (e.g. -6) to trigger edge cases for large shifting

What do you think @MartinRaetz ? I would do that in other issues to keep this one focused on the timezone aspect.

@TobiasSpratte
Copy link
Contributor

I have checked the exported .mos and .epw files in EnergyPlus, Spawn and Modelica and everything works as expected. Thank you @FWuellhorst !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export time zone - customizable or similar to import
3 participants