Make leader election idempotent #325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelby-moore-sh
approved these changes
May 13, 2025
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic
branch
2 times, most recently
from
1b062eb to
693fc3d
Compare
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic
branch
2 times, most recently
from
03ee192 to
bc51afd
Compare
ChrisBr
commented
May 14, 2025
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic
branch
from
bc51afd to
4aaf178
Compare
casperisfine
approved these changes
May 14, 2025
shelby-moore-sh
approved these changes
May 14, 2025
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic
branch
from
0463f1e to
7d956db
Compare
ChrisBr
force-pushed
the
cbruckmayer/make-setnx-atomic
branch
from
7d956db to
9038dc1
Compare
|
Superseded by #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setnxwhich we use during leader election is not safe to retry via Redisreconnect_attemptsas the command could succeed on the Redis server but we run into a client read timeout. In this case, any subsequentsetnxcalls will returnfalseand leader election will fail.Instead we're now setting a uniq value for
setupand compare it when we fail.