Feature/FA-2-Forget-Password #11

EslamMagdy12 · 2025-03-30T14:58:18Z

This pull request implements the Forget Password, Email Verification, and Reset Password functionalities, integrating them seamlessly across the data, domain, and presentation layers. These enhancements ensure a smoother password recovery experience for users while improving code maintainability and structure. Additionally, minor optimizations and refactoring were done to enhance performance and maintain consistency across the project.

Changes Included:

🔹 Data Layer:

Added API endpoints in AuthRetrofitClient for:
- Sending a forget password request.
- Verifying the reset code.
- Resetting the password.
Implemented Auth Remote Data Source to manage authentication-related API calls.
Created request and response models for:
- forget_password
- verify_reset_code
- reset_password
Developed the Auth Repository Implementation to handle data fetching and processing.

🔹 Domain Layer:

Created new use cases for handling:
- Forget password requests.
- Reset code verification.
- Password reset submission.
Integrated repository contracts to ensure structured data handling.

🔹 Presentation Layer:

Developed dedicated screens for:
- Forget Password
- Email Verification
- Reset Password
Enhanced UI elements to provide a more user-friendly experience.
Improved widget performance by using const where applicable.

🔹 Localization & UI Enhancements:

Updated Arabic & English translation files (ar.json & en.json) to include new authentication-related strings.
Introduced PIN input theme customizations in app_theme.dart.

🔹 General Improvements:

Refactored API Exception Handling:
- Renamed app_exception.dart to api_exception.dart for better clarity.
- Updated all related imports accordingly.
- Improved _extractErrorMessage in ApiManager to handle API errors more effectively.
Navigation Updates:
- Registered Forget Password, Email Verification, and Reset Password routes in routes.dart.

📌 Pull Request Checklist

✅ General

This pull request is all my own work -- I have not plagiarized it.
The PR title follows the required format: type/FA-<issue-number>-TaskName.
The branch name follows the required format: feature/meaningful-name, fix/issue-description, etc.

📂 Code Quality

All filenames are in snake_case.
All functions and variable names follow Dart naming conventions.
All new code is formatted with dart format .

🛠 CI/CD Validation

Linting passes with dart analyze.
The branch name is validated against the allowed patterns.
The PR title is validated against the required format.

🚀 Testing

Unit tests are included for all new features and bug fixes.
flutter test --coverage has been run and the results reviewed.
The project builds successfully without errors.

📝 Additional Information

This update enhances the password recovery process, ensuring a structured and scalable implementation while improving user experience. Future updates will focus on adding unit tests to validate functionality and maintain reliability.

🔗 Related JIRA Ticket(s):

JIRA Issue: FA-2

📸 Screenshots (if applicable):

Forget Password	Email Verification	Reset Password

…ing cubit as a state management.

…splayed error message returned from api.

…emove unused imports, and remove relying on hardcoded colors and used the app_colors.

… analyze.

- All fields are required in request models. - Added some missed async and await. - Removed Pintheme from AppTheme. - Removed BlocConsumer and used BlocListener Instead. - Renamed again ApiException to AppException. - Followed the same Architecture so moved Auth Remote DataSource Impl outside implementation folder

lib/features/auth/presentation/view_model/reset_password_cubit.dart

lib/features/auth/presentation/view_model/forget_password_cubit.dart

lib/features/auth/presentation/view_model/email_verification_state.dart

lib/features/auth/presentation/view_model/forget_password_state.dart

lib/features/auth/presentation/view/widgets/reset_password_form.dart

lib/features/auth/presentation/view/widgets/verification_code_input.dart

- Used Cubits with BaseState, and Equatable. - Renamed forget_password_header to header because it used across many screens not just forget_password

- Added unit tests for ForgetPasswordUsecase, ResetPasswordUsecase, and VerifyResetCodeUsecase. - Utilized Mockito for mocking the AuthRepo dependency. - Ensured tests cover both success and failure scenarios for each use case. - Updated dependencies and configurations to support testing. - Removed the default widget test file.

…forget-password # Conflicts: # lib/core/utils/di/di.config.dart # lib/core/utils/routes/routes.dart # lib/main.dart # pubspec.lock # test/widget_test.dart

ali72-20

great job eslam perfect style
keep going

lib/features/auth/data/data_source/remote/auth_remote_data_source_impl.dart

lib/features/auth/presentation/view/widgets/resend_code.dart

lib/features/auth/presentation/view/widgets/verification_code_input.dart

- Updated forget password screens and widgets to depend on AppColors file - Update localization files to include (Resend In) text

- Replaced public variables with private ones in: - AuthRemoteDataSourceImpl - EmailVerificationCubit - ForgetPasswordCubit - This enhances encapsulation and prevents unintended external access.

- Included unit tests for the following components: - Forget Password Cubit - Auth Repository Implementation - Auth Remote Data Source Implementation - Forget Password Usecase - Reset Password Usecase - Verify Reset Code Usecase

- Prevents memory leaks by canceling the timer in the `dispose` method.

…forget-password # Conflicts: # assets/translations/ar.json # assets/translations/en.json # lib/core/utils/datasource_excution/api_manager.dart # lib/core/utils/di/di.config.dart # lib/core/utils/routes/routes.dart # lib/features/auth/data/data_source/contract/auth_remote_data_source.dart # lib/features/auth/data/data_source/remote/auth_remote_data_source_impl.dart # lib/features/auth/data/repo_impl/auth_repo_impl.dart # lib/features/auth/domain/repo/auth_repo.dart # lib/features/home/data/api/home_retrofit_client.dart # lib/features/home/data/api/home_retrofit_client.g.dart # lib/main.dart # pubspec.lock # pubspec.yaml

…e issues

…and ensured no issues when did dart analyze

Feature/FA-100-Merge-Final-One

…feature/fa-2-forget-password # Conflicts: # assets/translations/ar.json # assets/translations/en.json # lib/core/utils/di/di.config.dart # lib/core/utils/routes/routes.dart # pubspec.yaml

…rt analysis no issues

… components

…set password forms

…or consistency, and updated skeletonizer package.

chore(pubspec): update package versions in pubspec.lock

…ration

Fix link of demo video

EslamMagdy12 added 8 commits March 24, 2025 20:17

feat(auth): implement forget and reset password data layer.

be02d9c

feat(auth): implement forget and reset password domain layer.

ba313ba

Merge branch 'refs/heads/developement' into Feature/FA-2-Forget-Password

a29737e

feat(auth): implement forget and reset password presentation layer us…

f3949a0

…ing cubit as a state management.

refactor(api): rename app_exception.dart to api_exception.dart and di…

dde50de

…splayed error message returned from api.

refactor(auth): update widgets to use const for better performance, r…

31fa210

…emove unused imports, and remove relying on hardcoded colors and used the app_colors.

refactor(auth): reformat and analyze codes using dart format and dart…

26eba80

… analyze.

EslamMagdy12 added the enhancement New feature or request label Mar 30, 2025

EslamMagdy12 self-assigned this Mar 30, 2025

EslamMagdy12 requested a review from ali72-20 as a code owner March 30, 2025 14:58

EslamMagdy12 mentioned this pull request Mar 30, 2025

Feature/FA-2-Forget-Password ✅ #3

Closed

13 tasks

ahmedelazab1220 requested review from Ahmed-Abdelghany-11, ahmedelazab1220, john-safwat and Ammar720 March 30, 2025 15:17

ahmedelazab1220 requested changes Mar 30, 2025

View reviewed changes

EslamMagdy12 added 3 commits March 30, 2025 20:28

refactor(auth): refactor forget password

20abd92

- Used Cubits with BaseState, and Equatable. - Renamed forget_password_header to header because it used across many screens not just forget_password

Merge remote-tracking branch 'origin/developement' into feature/fa-2-…

363e711

…forget-password # Conflicts: # lib/core/utils/di/di.config.dart # lib/core/utils/routes/routes.dart # lib/main.dart # pubspec.lock # test/widget_test.dart

ali72-20 approved these changes Apr 7, 2025

View reviewed changes

EslamMagdy12 added 4 commits April 7, 2025 22:27

refactor(auth): Refactor Forget Password

dc0a7d2

- Updated forget password screens and widgets to depend on AppColors file - Update localization files to include (Resend In) text

refactor(auth): Use private variables in Cubits and Data Sources

9aef9bb

- Replaced public variables with private ones in: - AuthRemoteDataSourceImpl - EmailVerificationCubit - ForgetPasswordCubit - This enhances encapsulation and prevents unintended external access.

refactor(test): deleted anything related to testing

2d4271d

ahmedelazab1220 changed the title ~~Feature/FA-2-Forget-Password ✅~~ Feature/FA-2-Forget-Password Apr 14, 2025

EslamMagdy12 added 4 commits April 24, 2025 02:32

refactor(auth): dispose timer in ResendCode widget

502b33e

- Prevents memory leaks by canceling the timer in the `dispose` method.

refactor(auth): merged dev into forget password branch, and fixed som…

571b966

…e issues

refactor(auth): reformated using dart format --set-exit-if-changed . …

3d3f00d

…and ensured no issues when did dart analyze

EslamMagdy12 and others added 17 commits April 24, 2025 15:59

refactor(auth): standardize use case naming and improve import paths

310eca2

Merge pull request #60 from ahmedelazab1220/developement

c08d0e3

Feature/FA-100-Merge-Final-One

Merge remote-tracking branch 'refs/remotes/origin/developement' into …

f146612

…feature/fa-2-forget-password # Conflicts: # assets/translations/ar.json # assets/translations/en.json # lib/core/utils/di/di.config.dart # lib/core/utils/routes/routes.dart # pubspec.yaml

fix(routes): update initial route to use dynamic route initializer.

346e354

refactor(forget-password): merged dev to fix conflicts and ensured da…

6eaadec

…rt analysis no issues

refactor(forget-password): update forget password flow and improve UI…

197ea2e

… components

refactor(forget-password): simplify button structure in forget and re…

d8589bb

…set password forms

fix(theme, dependencies): update dialogTheme to use DialogThemeData f…

d36e7ab

…or consistency, and updated skeletonizer package.

Create LICENSE

d4ea0fb

docs(README): enhance project overview and architecture details

31992e7

chore(pubspec): update package versions in pubspec.lock

Merge branch 'main' of github.com:ahmedelazab1220/ecommerce_flower_app

cbe6c64

docs(README): add additional sources for dependency injection configu…

dbc4b7a

…ration

Update README.md

d11b9c2

Fix link of demo video

Update README.md

e52301b

Merge branch 'main' into developement

6c51e06

Merge branch 'main' into feature/fa-2-forget-password

62f6d10

Merge branch 'developement' into feature/fa-2-forget-password

b435c8b

Ammar720 approved these changes Jul 18, 2025

View reviewed changes

Ammar720 requested a review from ahmedelazab1220 July 18, 2025 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/FA-2-Forget-Password #11

Feature/FA-2-Forget-Password #11

Uh oh!

EslamMagdy12 commented Mar 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ali72-20 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Feature/FA-2-Forget-Password #11

Are you sure you want to change the base?

Feature/FA-2-Forget-Password #11

Uh oh!

Conversation

EslamMagdy12 commented Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Included:

🔹 Data Layer:

🔹 Domain Layer:

🔹 Presentation Layer:

🔹 Localization & UI Enhancements:

🔹 General Improvements:

📌 Pull Request Checklist

✅ General

📂 Code Quality

🛠 CI/CD Validation

🚀 Testing

📝 Additional Information

🔗 Related JIRA Ticket(s):

📸 Screenshots (if applicable):

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ali72-20 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EslamMagdy12 commented Mar 30, 2025 •

edited

Loading