pinocchio: Use SIMD-0194 exemption threshold value #243
+67
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
force-pushed
the
febo/simd-0194-exemption-threshold
branch
from
b093fe3 to
eb7160f
Compare
joncinque
approved these changes
Sep 12, 2025
Comment on lines
+175
to
176
| #[allow(deprecated)] | ||
| pub fn due_amount(&self, data_len: usize, years_elapsed: f64) -> u64 { |
There was a problem hiding this comment.
This can be done in future work, but how about just deprecating this function?
There was a problem hiding this comment.
Yeah, that is a good point. We should be using the SDK crate for rent in the very near future, so we can make these changes there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SIMD-0194 will deprecate the
exemption_thresholdvalue and set it to1.0. This will "break" the current logic to avoidf64operations in the minimum balance calculation.Solution
Use the SIMD-0194 value to avoid
f64operations. This PR also adds deprecation notes for changes proposed in SIMD-0194.