Skip to content

Conversation

kwin
Copy link
Member

@kwin kwin commented Aug 5, 2025

Separate abstract classes for read and write SCM operation

This closes #1384

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Separate abstract classes for read and write SCM operation

This closes #1384
@kwin kwin requested a review from michael-o August 5, 2025 09:41
@michael-o
Copy link
Member

What is the motivation here?

@kwin
Copy link
Member Author

kwin commented Aug 5, 2025

To align with what is possible in maven-scm-publish-plugin. Also the hardcoded default lookup mechanism of server ids derived from URLs is just too static (often credentials are shared among multiple hosts/ports).

Also the undocumented property

descriptor.setScmId(project.getProperties().getProperty("project.scm.id"));
is just too well hidden.

@kwin kwin requested a review from cstamas August 6, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to configure SCM id and privateKey as Mojo parameter
2 participants