Reduce amount of log junk emitted #1286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
changed the title
kwin
requested changes
Aug 11, 2025
| @@ -54,7 +54,7 @@ public void execute() throws MojoExecutionException { | |||
|
|
|||
| checkResult(result); | |||
|
|
|||
| getLog().info("" + result.getAddedFiles().size() + " files successfully added."); | |||
| getLog().debug("" + result.getAddedFiles().size() + " files successfully added."); | |||
There was a problem hiding this comment.
This I would rather leave with info as this is an important hint as often usage of wildcards leads to unexpected files being added. I think one info per goal is not overly verbose.
| @@ -61,7 +61,7 @@ public CheckLocalModificationsMojo(ScmManager manager, SettingsDecrypter setting | |||
|
|
|||
| public void execute() throws MojoExecutionException { | |||
| if (skip) { | |||
| getLog().info("check-local-modification execution has been skipped"); | |||
There was a problem hiding this comment.
I think skipping a mojo emits an INFO log also with other mojos, like https://github.com/apache/maven-surefire/blob/98d081e671888831ab16c66f4e02fc7e73802d2f/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L939. I would rather leave on info level.
|
|
||
| if (project.getProperties() != null) // Remove the test when we'll use plugin-test-harness 1.0-alpha-2 | ||
| { | ||
| project.getProperties().put(revisionKey, revision); | ||
| } | ||
|
|
||
| getLog().info("Project at revision " + revision); | ||
| getLog().debug("Project at revision " + revision); |
There was a problem hiding this comment.
This is important to leave on INFO for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes a lot of info logs statements to debug