Fix base_dir updating for nested .xsd dependencies #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not aware of this behaviour. Can you please also write a test for it? |
|
BTW, thanks a lot for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say we have the directory structure as follows:
/BASE.xsd--> Depends ondeps/Dep1.xsd/deps/Dep1.xsd--> Depends onDep2.xsd/deps/Dep2.xsdParsing
BASE.xsdfrom within its containing folder would result inbase_dirbeing.for all nested folders within. So when./deps/Dep1.xsdis parsed, it will be unable to findDep2.xsdbecause it will look in the parent directory.instead of./deps