Skip to content

Conversation

tpadioleau
Copy link
Member

This PR removes the mix of rocm 6.1.2 and rocm 6.3.3 on Adastra by declaring rocm 6.3.3 packages in packages.yaml. This file has been generated from the file provided by the CINES configuration in rocm 6.1.2, some packages have been removed.

As a consequence this provides a uniform environment and simplifies the file environment.sh.


Please complete the checklist to ensure that all tasks are completed before marking your pull request as ready for review.

All Submissions

  • Have you ensured that all lines changed in this PR are justified by a comment found in the description ?
  • Have you updated the CHANGELOG.md ?
  • Have you linked any issues that should be closed when this PR is merged (using closing keywords) ?
  • Have you checked that the AUTHORS file is up to date ?
  • Have you checked that the copyright information in the LICENCE file is up to date (including dates) ?
  • Do you follow the conventions specified in our coding standards ?

New Feature Submissions

  • Have you added tests for the new functionalities ?
  • Have you documented the new functionalities:
    • API documentation describing the available methods, when each should be used and how to use them ?
    • User-friendly documentation in README files (which may link to the API documentation).
    • If the new functionality is non-trivial to use, provide a tutorial or example ? (optional)

Changes to Existing Features

  • Have you checked that existing tests cover all code after the changes ?
  • Have you checked that existing tests are still passing ?
  • Have you checked that the existing documentation is still accurate (API and README files) ?

Changes to the CI

  • Have you made the same changes to both the GitHub CI and the GitLab CI (for the private fork) ?

@EmilyBourne EmilyBourne requested a review from etiennemlb August 28, 2025 08:38
@tpadioleau tpadioleau added the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Sep 11, 2025
@tpadioleau tpadioleau self-assigned this Sep 11, 2025
@github-actions github-actions bot added Ready to merge Label to be automatically added to a PR when it is approved and tests are passing and removed Ready to review Label to be automatically added to a PR when it is ready to be reviewed labels Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label to be automatically added to a PR when it is approved and tests are passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants