Skip to content

squit browser: fix false positive "repository disappeared" label if there are no projects #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

squit browser: fix false positive "repository disappeared" label if there are no projects #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Squit.package/SquitBrowser.class/instance/branchListIfRepositoryDoesNotExist.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
ui
branchListIfRepositoryDoesNotExist
^ #('-- Repository disappeared --')
^ self projectList size > 1
ifTrue: [#('-- Repository disappeared --')]
ifFalse: [#('-- Branches --')]
2 changes: 1 addition & 1 deletion src/Squit.package/SquitBrowser.class/instance/refresh.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ refresh
self hasProjectSelection ifFalse:
[selectedHistorian := nil.
commitSelection := nil.
branchList := self branchListIfRepositoryDoesNotExist.
branchList := nil.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...because branchList still answers the branchListIfRepositoresDoesNotExist if no project is selected. So why not already populate that here.

indexOfActiveHistorianInBranchList := 0.
cachedCommitList := #().
self changed: #branchList;
Expand Down
4 changes: 2 additions & 2 deletions src/Squit.package/SquitBrowser.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"branchButtonHelpText" : "jr 12/22/2021 21:09",
"branchList" : "jr 12/22/2021 23:46",
"branchListIconAt:" : "jr 5/14/2021 22:57",
"branchListIfRepositoryDoesNotExist" : "jr 12/22/2021 23:45",
"branchListIfRepositoryDoesNotExist" : "ct 10/4/2022 18:54",
"branchListMenu:shifted:" : "jr 1/13/2018 00:31",
"branchSelection" : "jr 6/27/2020 09:50",
"branchSelection:" : "jr 2/27/2020 00:58",
Expand Down Expand Up @@ -182,7 +182,7 @@
"push:toRemoteNamed:" : "ct 9/15/2022 19:05",
"pushBranch" : "jr 7/2/2022 22:16",
"rebuildCommitList" : "jr 7/2/2022 22:15",
"refresh" : "jr 12/22/2021 23:46",
"refresh" : "ct 10/4/2022 18:54",
"remotesMenuWithItems:" : "jr 3/4/2020 01:01",
"remotesPushSubMenu" : "jr 5/30/2019 01:14",
"removeTrackedRemoteBranch:" : "jr 8/10/2020 22:25",
Expand Down