Workaround for root spans with alien FOLLOWS_FROM references
#2428
+36
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Chaldecott <james@swythan.co.uk>
Signed-off-by: James Chaldecott <james@swythan.co.uk>
yurishkuro
reviewed
Sep 9, 2024
packages/jaeger-ui/src/components/TracePage/CriticalPath/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: James Chaldecott <james@swythan.co.uk>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
FOLLOWS_FROMreference in another trace #2427Description of the changes
These were the changes I had to make locally (in the Chrome debug tools) to prevent the page from crashing when the root span had a
FOLLOWS_FROMreference from a different trace.How was this change tested?
Only by making these changes directly in the minified sources in Chrome/Edge's "Local Overrides". It stopped things failing, but I'm not sure whether the actual critical path algorithm still works afterwards.
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test