Pr 3002

[iypetrov]

Which problem is this PR solving?

Extends #3002
Previously Deep Dependencies view was always using /analytics/v1/deep-dependencies API endpoint to retrieve the data. Now this endpoint is configurable via UI config, but the default is changed to /api/deep-dependencies to match the change in the backend jaegertracing/jaeger#6606 that returns dummy data for said endpoint.

Part of jaegertracing/jaeger#7399.

Description of the changes

How was this change tested?

• Unit tests

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: npm run lint and npm run test

[graphite-app]

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[yurishkuro]

Use of ? indicates the value might be null, why should it be allowed?

[yurishkuro]

I understand you're just copying preexisting pattern, but I wonder why these need to be optional if our default config will always overwrite them if not defined? It seems not using optional will make the rest of the code simpler.

[Copilot]

Pull Request Overview

This PR configures the Deep Dependencies API endpoint to use a new configurable path instead of the hardcoded analytics endpoint. The default endpoint is changed from /analytics/v1/deep-dependencies to /api/deep-dependencies to align with backend changes that provide dummy data for this endpoint.

• Adds configurable apiEndpoint and menuLabel options to the deepDependencies configuration
• Updates the default configuration to use /api/deep-dependencies as the new endpoint
• Refactors the API implementation to use the configurable endpoint instead of hardcoded analytics path

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
packages/jaeger-ui/src/types/config.tsx	Adds type definitions for new configurable deep dependencies options
packages/jaeger-ui/src/constants/default-config.tsx	Sets default values for the new deep dependencies configuration
packages/jaeger-ui/src/api/jaeger.js	Updates API implementation to use configurable endpoint instead of hardcoded analytics path
packages/jaeger-ui/src/api/jaeger.test.js	Updates test to reflect the new endpoint constant name

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The getConfig().deepDependencies?.apiEndpoint could be undefined if the configuration is not properly initialized, which would cause prefixUrl(undefined) to be called. This should have a fallback value or be wrapped in a function to ensure the config is available when accessed.

Suggested change

	export const DEEP_DEPENDENCIES_ROOT = prefixUrl(getConfig().deepDependencies?.apiEndpoint);
	export const DEEP_DEPENDENCIES_ROOT = prefixUrl(getConfig().deepDependencies?.apiEndpoint || '/api/dependencies');

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (b375fa5) to head (16f16db).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3058   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         257      257           
  Lines        8004     8004           
  Branches     2014     2014           
=======================================
  Hits         7855     7855           
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.