Add Guile support for Scheme implementation #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanaka
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Hello @wasamasa sorry for the very slow reply (I've been unable to work on this project for the past couple of years but I'm am now able to again). If you're still interested in getting this merged can you rebase this and make sure that all the Github CI tests pass? The CI process should be much more automatic now, no need for me to manually build/push docker images).
wasamasa
force-pushed
the
add-scheme-guile-support
branch
from
40f40d6 to
9f90341
Compare
|
Thanks, I've successfully rebased the changes and the build was successful. |
kanaka
requested changes
Aug 28, 2024
kanaka
added
the
new_implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that Guile 3.0 has almost complete R7RS support these days, so I've edited the Dockerfile accordingly and added one hack to make tests pass.