Skip to content

Implement saiten adjustment screen #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Implement saiten adjustment screen #38

wants to merge 12 commits into from

Conversation

andy840119
Copy link
Member

Implementation of #34

@andy840119 andy840119 added the enhancement New feature or request label Mar 9, 2020
@andy840119 andy840119 self-assigned this Mar 9, 2020
@andy840119
Copy link
Member Author

will crash at dependencies
Maybe see how PlayerTestScene work

@andy840119
Make it work
7bb2b3e 
TODO : adjust UI and let `DrawableSaitenAdjustmentRuleset` use `NotePlayfield` only
@andy840119
TODO : skin is not being applied
048dc30
@andy840119
Apply skin source
34c77df
@andy840119
Clean-up code
259c396
@andy840119
Copy link
Member Author

dependencies issue is solved.
TODO :

  • Implement config button follow prototype
  • Deal with karaoke session

@andy840119
Copy link
Member Author

Oops, should move regist into SaitenAdjustmentScreen, and remove session static.
Also, making button list in child?
Not sure.

@andy840119
Merge branch 'master' of https://github.com/andy840119/osu-Karaoke in…
41b3e25 
…to andy840119/_saiten-adjustment
@andy840119
Wait
47a5d10 
All the regist code can be removed?
@andy840119
Merge branch 'master' of https://github.com/osu-Karaoke/osu-Karaoke i…
8aaffd1 
…nto andy840119/_saiten-adjustment

# Conflicts:
#	osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj
@andy840119
Fix compile error and remove extra setting in csproj
a0fc6bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andy840119 andy840119

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119