Adds optional callback method (logger) for Observable.log/spy() #315
+42
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I personally like this change. On #318 I'm proposing we drop support for node 6 and 8 (and maybe 10) which means tests would pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use-case where I would like to log/spy using function other than
console.logand I don't want to override thelogmethod onconsole. This PR should make this possible.(Ofc, it is possible to simply wrap the observer and build the desired functionality yourself, but it would be more convenient, if this option comes from library itself.)
PS. Looks like CI pipelines for Node 6/8 are broken.