Fixes #3320 (UPDATED) — when a draggable element is inside a rotated parent, its drag direction is incorrect #3331
+224
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3320
Updated PR so now it fixes both direction and momentum of child draggable in rotated parent container.
packages/framer-motion/src/gestures/drag/VisualElementDragControls.ts
updateAxis
to check if a draggable has a rotated parent.- Added
checkForRotatedParent
helper function to detect rotation in the parent.- Added
calculatedInverseMatrix
helper function to create the inverse rotation matrix of the parent container's rotation.- Added
calculateInvertedPoint
helper function to multiply the inverse matrix with the offset.- Applies inverse matrix to velocity if in a rotated parent
packages/framer-motion/src/gestures/drag/__tests__/index.test.tsx