Skip to content

Fixing a recording glitch #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fixing a recording glitch #4802

wants to merge 2 commits into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Mar 14, 2025 •
edited
Loading

Main bug should be fixed however,

Noticing bug where after

  1. Entering locked mode
  2. Flipping orientation twice
  3. Exiting locked mode
  4. Flipping again -> causing spreedCapabilities to be null

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Mar 14, 2025
@rapterjet2004 rapterjet2004 self-assigned this Mar 14, 2025
@rapterjet2004 rapterjet2004 force-pushed the issue-3552-recording-glitch branch from faaf458 to 2d55bce Compare March 17, 2025 16:48
@rapterjet2004 rapterjet2004 marked this pull request as ready for review March 17, 2025 16:50
@rapterjet2004 rapterjet2004 marked this pull request as draft March 17, 2025 17:31
@rapterjet2004
this should work - didn't test yet tho
03c5d25 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-3552-recording-glitch branch from 2d55bce to 03c5d25 Compare April 14, 2025 16:01
@rapterjet2004
WIP
53c4329 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9897
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222118
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310206

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4802-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rapterjet2004 rapterjet2004

Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Voice message recording sometimes stops unexpectedly
1 participant
@rapterjet2004