Skip to content

Conversation

leosvelperez
Copy link
Member

Current Behavior

When running an npm script through nx and not using the PseudoTerminal, child processes might not be killed when the nx:run-script executor is killed.

Expected Behavior

When running an npm script through nx and not using the PseudoTerminal, child processes should be killed when the nx:run-script executor is killed.

@leosvelperez leosvelperez self-assigned this Sep 11, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner September 11, 2025 13:46
Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 11, 2025 3:36pm

Copy link
Contributor

nx-cloud bot commented Sep 11, 2025

View your CI Pipeline Execution ↗ for commit 550ba11

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 41m 33s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 10s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 4m 35s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-11 16:08:45 UTC

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

fix(gradle): correct LARGE_BUFFER import path

We verified this fix by re-running gradle:build-base.

Suggested Fix changes
diff --git a/packages/gradle/src/executors/gradle/gradle-batch.impl.ts b/packages/gradle/src/executors/gradle/gradle-batch.impl.ts
index b43d058..0bc9aec 100644
--- a/packages/gradle/src/executors/gradle/gradle-batch.impl.ts
+++ b/packages/gradle/src/executors/gradle/gradle-batch.impl.ts
@@ -5,10 +5,8 @@ import {
   TaskGraph,
   workspaceRoot,
 } from '@nx/devkit';
-import {
-  LARGE_BUFFER,
-  RunCommandsOptions,
-} from 'nx/src/executors/run-commands/run-commands.impl';
+import { RunCommandsOptions } from 'nx/src/executors/run-commands/run-commands.impl';
+import { LARGE_BUFFER } from 'nx/src/executors/utils/buffer';
 import { BatchResults } from 'nx/src/tasks-runner/batch/batch-messages';
 import { GradleExecutorSchema } from './schema';
 import { findGradlewFile } from '../../utils/exec-gradle';
diff --git a/packages/gradle/src/utils/exec-gradle.ts b/packages/gradle/src/utils/exec-gradle.ts
index 543db1e..a1ce4f3 100644
--- a/packages/gradle/src/utils/exec-gradle.ts
+++ b/packages/gradle/src/utils/exec-gradle.ts
@@ -2,7 +2,7 @@ import { AggregateCreateNodesError, workspaceRoot } from '@nx/devkit';
 import { ExecFileOptions, execFile } from 'node:child_process';
 import { existsSync } from 'node:fs';
 import { dirname, join } from 'node:path';
-import { LARGE_BUFFER } from 'nx/src/executors/run-commands/run-commands.impl';
+import { LARGE_BUFFER } from 'nx/src/executors/utils/buffer';
 
 export const fileSeparator = process.platform.startsWith('win')
   ? 'file:///'

❌ The fix was rejected.

Nx CloudView interactive diff and more actions ↗


⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant