Skip to content
This repository was archived by the owner on Feb 1, 2024. It is now read-only.

Fixed plugin loading #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed plugin loading #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
260 changes: 153 additions & 107 deletions lib/dynamodb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,85 +1,126 @@
'use strict';
"use strict";

const zlib = require('zlib');
const debug = require('debug')('plugin:dynamodb');
const zlib = require("zlib");
const debug = require("debug")("plugin:dynamodb");

var aws = require('aws-sdk'),
dynamodb = new aws.DynamoDB(),
constants = {
PLUGIN_NAME: 'dynamodb',
PLUGIN_PARAM_TABLE: 'table',
PLUGIN_PARAM_CREATETABLE: 'createTable',
THE: 'The "',
CONFIG_REQUIRED: '" plugin requires configuration under <script>.config.plugins.',
PARAM_REQUIRED: '" parameter is required',
PARAM_MUST_BE_STRING: '" param must have a string value',
PARAM_MUST_HAVE_LENGTH_OF_AT_LEAST_ONE: '" param must have a length of at least one',
PARAM_MUST_BE_ARRAY: '" param must have an array value',
// Report Array Positions
TIMESTAMP: 0,
REQUEST_ID: 1,
LATENCY: 2,
STATUS_CODE: 3
},
messages = {
pluginConfigRequired: constants.THE + constants.PLUGIN_NAME + constants.CONFIG_REQUIRED + constants.PLUGIN_NAME,
pluginParamTableRequired: constants.THE + constants.PLUGIN_PARAM_TABLE + constants.PARAM_REQUIRED,
pluginParamTableMustBeString: constants.THE + constants.PLUGIN_PARAM_TABLE + constants.PARAM_MUST_BE_STRING,
pluginParamTableMustHaveALengthOfAtLeastOne: constants.THE + constants.PLUGIN_PARAM_TABLE + constants.PARAM_MUST_HAVE_LENGTH_OF_AT_LEAST_ONE
},
impl = {
validateConfig: function(scriptConfig) {
// Validate that plugin config exists
if (!(scriptConfig && scriptConfig.plugins && constants.PLUGIN_NAME in scriptConfig.plugins)) {
throw new Error(messages.pluginConfigRequired);
}
// Validate TABLE
if (!(constants.PLUGIN_PARAM_TABLE in scriptConfig.plugins[constants.PLUGIN_NAME])) {
throw new Error(messages.pluginParamTopicArnRequired);
} else if (!('string' === typeof scriptConfig.plugins[constants.PLUGIN_NAME][constants.PLUGIN_PARAM_TABLE] ||
scriptConfig.plugins[constants.PLUGIN_NAME][constants.PLUGIN_PARAM_TABLE] instanceof String)) {
throw new Error(messages.pluginParamTopicArnMustBeString);
} else if (scriptConfig.plugins[constants.PLUGIN_NAME][constants.PLUGIN_PARAM_TABLE].length === 0) {
throw new Error(messages.pluginParamTopicArnMustHaveALengthOfAtLeastOne);
}
},
createTable: function(config) {
let createTable = config[constants.PLUGIN_PARAM_CREATETABLE] ? config[constants.PLUGIN_PARAM_CREATETABLE] : false;
if (createTable) {
let tableName = config[constants.PLUGIN_PARAM_TABLE];
var params = {
AttributeDefinitions: [
{
AttributeName: "uid",
AttributeType: "S"
},
{
AttributeName: "timestamp",
AttributeType: "N"
}
],
KeySchema: [
{
AttributeName: "uid",
KeyType: "HASH"
},
{
AttributeName: "timestamp",
KeyType: "RANGE"
}
],
ProvisionedThroughput: {
ReadCapacityUnits: 5,
WriteCapacityUnits: 5
},
TableName: tableName
};
dynamodb.createTable(params, function(err, data) {
var aws = require("aws-sdk"),
dynamodb = new aws.DynamoDB(),
constants = {
PLUGIN_NAME: "dynamodb",
PLUGIN_PARAM_TABLE: "table",
PLUGIN_PARAM_CREATETABLE: "createTable",
THE: 'The "',
CONFIG_REQUIRED:
'" plugin requires configuration under <script>.config.plugins.',
PARAM_REQUIRED: '" parameter is required',
PARAM_MUST_BE_STRING: '" param must have a string value',
PARAM_MUST_HAVE_LENGTH_OF_AT_LEAST_ONE:
'" param must have a length of at least one',
PARAM_MUST_BE_ARRAY: '" param must have an array value',
// Report Array Positions
TIMESTAMP: 0,
REQUEST_ID: 1,
LATENCY: 2,
STATUS_CODE: 3,
},
messages = {
pluginConfigRequired:
constants.THE +
constants.PLUGIN_NAME +
constants.CONFIG_REQUIRED +
constants.PLUGIN_NAME,
pluginParamTableRequired:
constants.THE + constants.PLUGIN_PARAM_TABLE + constants.PARAM_REQUIRED,
pluginParamTableMustBeString:
constants.THE +
constants.PLUGIN_PARAM_TABLE +
constants.PARAM_MUST_BE_STRING,
pluginParamTableMustHaveALengthOfAtLeastOne:
constants.THE +
constants.PLUGIN_PARAM_TABLE +
constants.PARAM_MUST_HAVE_LENGTH_OF_AT_LEAST_ONE,
},
impl = {
validateConfig: function (scriptConfig) {
// Validate that plugin config exists
if (
!(
scriptConfig &&
scriptConfig.plugins &&
constants.PLUGIN_NAME in scriptConfig.plugins
)
) {
throw new Error(messages.pluginConfigRequired);
}
// Validate TABLE
if (
!(
constants.PLUGIN_PARAM_TABLE in
scriptConfig.plugins[constants.PLUGIN_NAME]
)
) {
throw new Error(messages.pluginParamTopicArnRequired);
} else if (
!(
"string" ===
typeof scriptConfig.plugins[constants.PLUGIN_NAME][
constants.PLUGIN_PARAM_TABLE
] ||
scriptConfig.plugins[constants.PLUGIN_NAME][
constants.PLUGIN_PARAM_TABLE
] instanceof String
)
) {
throw new Error(messages.pluginParamTopicArnMustBeString);
} else if (
scriptConfig.plugins[constants.PLUGIN_NAME][
constants.PLUGIN_PARAM_TABLE
].length === 0
) {
throw new Error(
messages.pluginParamTopicArnMustHaveALengthOfAtLeastOne
);
}
},
createTable: function (config) {
let createTable = config[constants.PLUGIN_PARAM_CREATETABLE]
? config[constants.PLUGIN_PARAM_CREATETABLE]
: false;
if (createTable) {
let tableName = config[constants.PLUGIN_PARAM_TABLE];
var params = {
AttributeDefinitions: [
{
AttributeName: "uid",
AttributeType: "S",
},
{
AttributeName: "timestamp",
AttributeType: "N",
},
],
KeySchema: [
{
AttributeName: "uid",
KeyType: "HASH",
},
{
AttributeName: "timestamp",
KeyType: "RANGE",
},
],
ProvisionedThroughput: {
ReadCapacityUnits: 5,
WriteCapacityUnits: 5,
},
TableName: tableName,
};
dynamodb.createTable(params, function (err, data) {
if (err) debug("WARNING: Error creating table", err);
});
}
},
updateItem: function(config, uid, timestamp, values) {
updateItem: function (config, uid, timestamp, values) {
let tableName = config[constants.PLUGIN_PARAM_TABLE];
let attributeNames = {};
let attributeValues = {};
Expand All @@ -90,64 +131,69 @@ var aws = require('aws-sdk'),
attributeValues[":" + property] = values[property];
updateExpression += " #" + property + " = :" + property + ",";
}
updateExpression = updateExpression.substr(0, updateExpression.length - 1);
var params = {
ExpressionAttributeNames: attributeNames,
ExpressionAttributeValues: attributeValues,
Key: {
"uid": {
"S": uid
},
"timestamp": {
"N": timestamp.toString()
}
},
ReturnValues: "ALL_NEW",
TableName: tableName,
UpdateExpression: updateExpression
};
updateExpression = updateExpression.substr(
0,
updateExpression.length - 1
);
var params = {
ExpressionAttributeNames: attributeNames,
ExpressionAttributeValues: attributeValues,
Key: {
uid: {
S: uid,
},
timestamp: {
N: timestamp.toString(),
},
},
ReturnValues: "ALL_NEW",
TableName: tableName,
UpdateExpression: updateExpression,
};
debug(JSON.stringify(params));
dynamodb.updateItem(params, function(err, data) {
if (err) debug("Error updating item", err, err.stack);
});
dynamodb.updateItem(params, function (err, data) {
if (err) debug("Error updating item", err, err.stack);
});
},
processLatencies: function(config, latencies) {
processLatencies: function (config, latencies) {
let count = latencies.length;
for (var index = 0; index < count; index++) {
var entry = latencies[index];
let values = {
latency: {
"N": entry[2].toString()
N: entry[2].toString(),
},
code: {
"S": entry[3].toString()
S: entry[3].toString(),
},
};
impl.updateItem(config, entry[1], entry[0], values);
}
},
DynamoDBPlugin: function(scriptConfig, eventEmitter) {
DynamoDBPlugin: function (scriptConfig, eventEmitter) {
var self = this,
reportError = function (err) {
if (err) {
debug('Error publishing to DynamoDB table:', err);
debug("Error publishing to DynamoDB table:", err);
}
};
self.config = JSON.parse(JSON.stringify(scriptConfig.plugins[constants.PLUGIN_NAME]));
self.config = JSON.parse(
JSON.stringify(scriptConfig.plugins[constants.PLUGIN_NAME])
);
impl.createTable(self.config);
eventEmitter.on('done', function (report) {
impl.processLatencies(self.config, report.latencies);
eventEmitter.on("done", function (report) {
// impl.processLatencies(self.config, report.latencies);
});
eventEmitter.on('stats', function (stats) {
eventEmitter.on("stats", function (stats) {
impl.processLatencies(self.config, stats._entries);
});
}
},
},
api = {
init: function (scriptConfig, eventEmitter) {
impl.validateConfig(scriptConfig);
return new impl.DynamoDBPlugin(scriptConfig, eventEmitter);
}
},
};

/**
Expand All @@ -168,5 +214,5 @@ module.exports = api.init;
module.exports.constants = constants;
module.exports.messages = messages;
module.exports.impl = impl;
module.exports.api = api;
module.exports.Plugin = api;
/* end-test-code */