Skip to content

prevent text overflow #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

prevent text overflow #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7bce19
open pr
jmonster Jan 21, 2025
787d1cb
prevent overflowing of text chart text
jmonster Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/components/charts/chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,13 +737,8 @@ export default class AstraChart extends ClassifiedElement {
// Line break (double space followed by a newline)
markdown = markdown.replace(/ \n/g, '<br>')

return html`<div
variant=${variant}
style=${`display: -webkit-box; -webkit-box-orient: vertical; overflow: hidden; font-family: Inter, sans-serif;`}
class="flex-1 self-start text-neutral-900 dark:text-neutral-100"
>
${unsafeHTML(markdown)}
</div>`
// add `truncate` here to get ellipsis working, but at the cost of losing visibility of most of the content
return html`<div variant=${variant} class="flex-1 self-start text-neutral-900 dark:text-neutral-100">${unsafeHTML(markdown)}</div>`
}

private renderAsSingleValue() {
Expand Down
16 changes: 9 additions & 7 deletions src/components/charts/composed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,16 @@ export default class AstraComposedChart extends AstraChart {
>
<div
id="composed-chart"
class=${`dark:text-neutral-100 text-neutral-950 h-full flex flex-col ${layer?.type === 'table' ? '' : 'p-5'} gap-4 rounded-lg bg-white dark:bg-black group/actions`}
class=${`dark:text-neutral-100 text-neutral-950 h-full ${layer?.type === 'table' ? '' : 'p-5'} gap-4 rounded-lg bg-white dark:bg-black group/actions`}
>
${layer?.type === 'single_value'
? // Single value charts show the highlights at the bottom of the card
html`${headerSection} ${chartSection}` // ${highlightSection} - Until more meaningful highlights are available, disabling for single value
: // All other charts show the highlights above the chart rendering
html`<div class=${`${layer?.type === 'table' ? 'p-5' : ''}`}>${headerSection} ${highlightSection}</div>
${chartSection}`}
<div class=${`flex flex-col flex-1 h-full ${layer?.type === 'text' ? 'overflow-hidden' : ''}`}>
${layer?.type === 'single_value'
? // Single value charts show the highlights at the bottom of the card
html`${headerSection} ${chartSection}` // ${highlightSection} - Until more meaningful highlights are available, disabling for single value
: // All other charts show the highlights above the chart rendering
html`<div class=${`${layer?.type === 'table' ? 'p-5' : ''}`}>${headerSection} ${highlightSection}</div>
${chartSection}`}
</div>
</div>
</div>
`
Expand Down