Enhance performance of get peer deps #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raineorshine
requested changes
Sep 22, 2025
| * @param version - The package version | ||
| * @returns Promise that resolves when peer dependencies are processed | ||
| */ | ||
| const processPeerDependencies = async ([pkg, version]: [string, Version]) => { |
There was a problem hiding this comment.
processPeerDependencies currently relies on a mutation side effect to return its results. Using a typical return statement so that this is a pure function with no side effects would be preferable.
raineorshine
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have expeiricned degregaded performance for a while now, and I finally got around to investingating it. Appreantly, the get peers deps did not have any conccurency controls, and when you have 150 packages, it spwans 150 processes at the same time, causing my CPU to choke for a good minute.
I fixed that and also added a caching mechanism