Next #18
Open
Next #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to pass httpsAgent argument over httpClient to apply a http proxy when create an EksiSozluk instance. It not worked. Seems object-assign-deep package not cover this case. It was a quick fix, needs more investigation.
|
the first test fails all the time, other tests pass with no problem. there is a problem with connection to the proxy somehow. need a fix... |
|
All tests passed but just the entries test failed. Somehow entries test not use the proxy. Every test passed when using the proxy in my local environment. Environment variables may not work in the test file? Need more investigation. |
|
Environment variables work. SSL problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.