Skip to content

NG17+ Comaptibility and Improvements #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

NG17+ Comaptibility and Improvements #1

wants to merge 7 commits into from

Conversation

davidda
Copy link

@davidda davidda commented Jun 19, 2024

Hi, I don't know if you are maintaining this project but if so I'd like to contribute my improvements.

  • Compatibility with Angular 16, 17, and possibly future versions as long as they don't have breaking changes that affect us.
  • fixed tests, added more
  • Changed Email and URL validators to use validator.js internally, providing a more proven and reliable method than custom regex.

@davidda
Copy link
Author

davidda commented Jun 28, 2024

As this repo seems to not be active anymore, I published my updated fork on npm: https://www.npmjs.com/package/@davidda/ngx-custom-validators
https://github.com/davidda/ngx-custom-validators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidda