Fix pagination text and no records message #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -33,6 +33,9 @@ export const TableScorecards: FC<Props> = (props: Props) => { | |||
| const { width: screenWidth }: WindowSize = useWindowSize() | |||
| const isTablet = useMemo(() => screenWidth <= 1000, [screenWidth]) | |||
|
|
|||
| const start = (props.page - 1) * (props.perPage ?? 0) + 1 | |||
There was a problem hiding this comment.
Consider adding a default value for props.perPage to avoid potential issues if it is undefined. For example, you could use a default value of 1 or another appropriate number.
| @@ -33,6 +33,9 @@ export const TableScorecards: FC<Props> = (props: Props) => { | |||
| const { width: screenWidth }: WindowSize = useWindowSize() | |||
| const isTablet = useMemo(() => screenWidth <= 1000, [screenWidth]) | |||
|
|
|||
| const start = (props.page - 1) * (props.perPage ?? 0) + 1 | |||
| const end = Math.min(props.page * (props.perPage ?? 0), props.metadata?.total ?? 0) | |||
There was a problem hiding this comment.
Similar to the previous line, ensure that props.perPage has a sensible default value to prevent unexpected behavior if it is undefined.
| {' '} | ||
| of | ||
| {' '} | ||
| {props.metadata.total} | ||
| {props.metadata?.total ?? 0} |
There was a problem hiding this comment.
Consider using a default value for props.metadata.total directly in the destructuring assignment or initialization to avoid using the nullish coalescing operator here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1502
What's in this PR?