-
Notifications
You must be signed in to change notification settings - Fork 41
Improve build for Linux using Makefile #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@8bitbubsy any chance to review this PR? 🙇🏻 |
So here's the honest reason for why I didn't give this PR attention (I usually give at least a reply, but I guess I forgot): I'm not comfortable with the whole Linux build files thing as it's impossible to satisfy all people. It just won't happen, there will always be new complaints about the make files/scripts at one point. cmake was supposed to be the absolute best and most versatile option (I thought?), but I guess it's not? These files are almost like holy ground, I'm not comfortable touching them too much, especially because I'm not a Linux guy myself and I have gotten so many complaints about the make solution for the tracker clones over the years. PS: why delete the existing .sh file? I'm sure it still works for most people. Marking it as executable in the repo is a good idea though, I didn't know it was possible! 👍 EDIT: Hmm, is it not possible to mark a file as executable with the GitHub Desktop client on Windows? How would I do this? |
I never had issues building a pt2-clone on linux. The process is simple and
never fails.
S.
…On Sat, 19 Jul 2025 at 11:01, Olav Sørensen ***@***.***> wrote:
*8bitbubsy* left a comment (8bitbubsy/pt2-clone#43)
<#43 (comment)>
So here's the honest reason for why I didn't give this PR attention (I
usually give at least a reply, but I guess I forgot): I'm not comfortable
with the whole Linux build files thing as it's impossible to satisfy all
people. It just won't happen, there will always be new complaints about the
make files/scripts at one point. cmake was supposed to be the absolute best
and most versatile option (I thought?), but I guess it's not? These files
are almost like holy ground, I'm not comfortable touching them too much,
especially because I'm not a Linux guy myself and I have gotten so many
complaints about the make solution for the tracker clones over the years.
PS: why delete the existing .sh file? I'm sure it still works for most
people. Marking it as executable in the repo is a good idea though, I
didn't know it was possible! 👍
—
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ6NUQIE3FPQNRVJWK4ZYT3JIJQTAVCNFSM6AAAAAB3OSFGDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJSGIZDSNJVGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@8bitbubsy thanks for your feedback! Regarding the choice between The outcome of this PR is to keep the same behavior of building in Linux but using a more common tool 👍🏻 - it can even be used for Mac, but I don't have Mac devices around to further test this, and running GitHub Actions to playaround with this may take me a while longer than expected. I'm not a Windows user since years, there are security permissions to modify the attributes of files to mark them as system, hidden or read-only, GPT says to do: git update-index --chmod=+x file.sh |
While there is already
cmake
and also severalmake-linux.sh
scripts, it should be best to use a Makefile, autoconf or another solution to allow user to customize the builds if needed, rather than defining hard-coded checks.Changes:
make-linux.sh
toMakefile
make-macos.sh
as executable in repo