Skip to content

Enabling domain resolution on Raft addresses #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

BHouwens
Copy link
Contributor

@BHouwens BHouwens commented Nov 22, 2023

Description

Enables the provision of domain names as entries in a node config, which is required for automated infrastructure setup. A unit test has been added for socket address construction, which works for both resolution of DNS and native IP addresses, but we will need to perform an integration test on this before merge.

NOTE: Domain names in the config will require defining the protocol explicitly. So you can use https://google.com but not google.com

Type of Change

Please mark the appropriate option by putting an "x" inside the brackets:

  • Bug fix
  • New feature
  • Enhancement or optimization
  • Documentation update
  • Other (please specify)

Checklist

Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have tested the changes locally and they work as expected.
  • I have added necessary documentation or updated existing documentation.
  • My code follows the project's coding standards and style guidelines.
  • I have added/updated relevant tests to ensure the changes are properly covered.
  • I have checked for and resolved any merge conflicts.
  • My commits have clear and descriptive messages.

Requested Reviewers

@BarryBoot asseblief 🙏

@BHouwens BHouwens requested a review from BarryBoot November 22, 2023 11:25
@BHouwens BHouwens merged commit 285f609 into develop Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant