Enabling domain resolution on Raft addresses #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables the provision of domain names as entries in a node config, which is required for automated infrastructure setup. A unit test has been added for socket address construction, which works for both resolution of DNS and native IP addresses, but we will need to perform an integration test on this before merge.
NOTE: Domain names in the config will require defining the protocol explicitly. So you can use
https://google.com
but notgoogle.com
Type of Change
Please mark the appropriate option by putting an "x" inside the brackets:
Checklist
Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!
Requested Reviewers
@BarryBoot asseblief 🙏